Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Rust][client] Add option to use rustls for reqwest instead of openssl #21001

Merged
merged 2 commits into from
Apr 6, 2025

Conversation

aran
Copy link
Contributor

@aran aran commented Mar 31, 2025

Generated Rust crates will allow configuring reqwest to use rustls via passthrough features.

fix: #19853

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @frol @farcaller @richardwhiuk @paladinzh @jacob-pro

aran added 2 commits March 31, 2025 12:25
Summary:

  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
@wing328
Copy link
Member

wing328 commented Apr 1, 2025

@aran thanks for the PR

allow configuring reqwest to use rustls via passthrough features.

I wonder if you can reply with some code snippets as examples showing how to do that.

@aran
Copy link
Contributor Author

aran commented Apr 1, 2025

Say I have a crate generated by openapi called mycrate. The user of mycrate would do:

mycrate = { version = "^1.0.0", default-features = false, features = ["rustls"] }

@wing328
Copy link
Member

wing328 commented Apr 1, 2025

thanks. if no one has further question/feedback, i'll merge this PR later this week

@wing328 wing328 merged commit b2abf36 into OpenAPITools:master Apr 6, 2025
19 checks passed
@aran aran deleted the 19853-rustls branch April 7, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [Rust] [Client] Add option to use rustls for reqwest instead of openssl
2 participants