Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Kotlin][WebClient] ApiClient is not compatible with spring-web 6 Observation API #21020

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NavruzshoevDaniel
Copy link

@NavruzshoevDaniel NavruzshoevDaniel commented Apr 2, 2025

…6 Observation API

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

ISSUE

#21017

@NavruzshoevDaniel
Copy link
Author

@wing328
Copy link
Member

wing328 commented Apr 7, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Apr 7, 2025

https://github.com/OpenAPITools/openapi-generator/actions/runs/14225635355/job/40120275535?pr=21020

please merge the latest master into your branch when you've time.

@NavruzshoevDaniel
Copy link
Author

NavruzshoevDaniel commented Apr 8, 2025

https://github.com/OpenAPITools/openapi-generator/actions/runs/14225635355/job/40120275535?pr=21020

please merge the latest master into your branch when you've time.

I've just fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants