-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Fix c curl generator #21103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix c curl generator #21103
Conversation
Hi! I just took a quick look at the new generated samples, and I see that petId for deletePet becomes a pointer. What's the point of that? The petId is not nullable, right? |
Also, would you mind adding some tests for these issues to the |
dc5639c
to
ba044a6
Compare
…nAPITools#21092)" This reverts commit ba044a6.
…nAPITools#21092)" This reverts commit f99c5b0.
…s#21092) - Convert float, double and long to string - Generate samples
Hi! Thanks for your answer @eafer ! Considering your comments, I changed the strategy. I added an example in petstore.yaml and I no longer change the function signature. |
Thanks. I can see a new |
…s#21092) - Add missing yaml example file
Sorry. I commited the missing yaml file. |
Thanks. Why did you set |
Fix for issue #21092
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@eafer