-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Remove jackson requirement, fixes #6881 #22169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
|
please also review the build failure when you've time |
5a04806 to
e292bfb
Compare
e292bfb to
f767c7b
Compare
|
@wing328 Done, re-added one import statement in the template that shouldn't have been removed. |
| convertPropertyToStringAndWriteBack(CodegenConstants.IMPL_FOLDER, this::setImplFolder); | ||
| convertPropertyToBooleanAndWriteBack(USE_BEANVALIDATION, this::setUseBeanValidation); | ||
| convertPropertyToBooleanAndWriteBack(USE_TAGS, this::setUseTags); | ||
| convertPropertyToBooleanAndWriteBack(JACKSON, this::setJackson); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about defaulting this option to true instead?
(I can do it in another PR instead)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the value is set to default true here
I assumed the property, if not explicitly configured, would not be present (and this method does not set anything if the property is not present). Is this okay or is this an incrrect assumption?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right. I was not expecting so many changes to the samples if the option is default to true but it turns out most changes are just removing empty lines
i'll test the option locally and merge if no question from me.
|
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) |
|
circleici failure (aws outage?) not related to this change |
Jackson was a requirement when using the server JAX-RS generator. Removing this requirement allows generating multi-platform code.
The PR is split into 3 commits (with a 4th for updating the samples/docs):
The 2nd can be its own PR if required, since not directly relevant to the linked issue. But its a small change and something that makes no sense as it was, so I just added it instead of having to get a reviewer's attention twice.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)