FIX #21407 - use referenced enum schema in request body if one is ava… #22178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)Description
This PR fixes #21407.
The core of this change is to treat a $ref to an enum schema as a model rather than a primitive String in a request body.
To achieve this, the
updateRequestBodyForStringmethod has been updated to accept the schema's component name. When this name is present, we delegate processing toaddBodyModelSchema. This mirrors the existing logic that is already present inupdateRequestBodyForObject, resulting in the proper enum type in the generated resource class API.This fixes also inline enums in request bodies when used in conjunction with RESOLVE_INLINE_ENUMS option set to true.
This is a breaking change for existing clients.