Skip to content

Conversation

@WannabeSoftwareEngineer
Copy link

@WannabeSoftwareEngineer WannabeSoftwareEngineer commented Oct 19, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Description

This PR fixes #21407.
The core of this change is to treat a $ref to an enum schema as a model rather than a primitive String in a request body.

To achieve this, the updateRequestBodyForString method has been updated to accept the schema's component name. When this name is present, we delegate processing to addBodyModelSchema. This mirrors the existing logic that is already present in updateRequestBodyForObject, resulting in the proper enum type in the generated resource class API.

This fixes also inline enums in request bodies when used in conjunction with RESOLVE_INLINE_ENUMS option set to true.

This is a breaking change for existing clients.

@WannabeSoftwareEngineer
Copy link
Author

Hi @wing328,
sorry for the delay.

what about considering this as a bug fix without the option to start with as we want to avoid option overload (too many options)?

if later users need ways to fallback, of course one way is to update the spec to remove enum from the string body definition.

This PR is the follow up of my previous PR 21410, where I removed the fallback option as you suggested.

I have a couple of questions for the checklist. After running

./mvnw clean package || exit
./bin/generate-samples.sh ./bin/configs/*.yaml || exit

I am looking at around ~369 files in the samples folder being updated. Do I need to commit all these files like mentioned in the guide?

./bin/utils/export_docs_generators.sh || exit

Could you also check if running the above command hangs for you too at this step?

[main] INFO  o.o.c.l.PythonFastAPIServerCodegen - Skipping sorting of path operations, order matters, let the developer decide via their specification file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] Enum in request body generates as String parameter, not Enum type

1 participant