Skip to content

Conversation

@KevinLiddle
Copy link
Contributor

This PR attempts to address 2 issues I am having with the rust-axum code generation for polymorphic types:

  1. The generated field for a discriminator property is not properly given a serde rename attribute with the camelCase version of the attribute name. This is inconsistent with other generated fields.
  2. The generated enum for a polymorphic type that uses a discriminator mapping does not do anything with the mapping names. This results in generated clients in other languages (e.g. TypeScript) passing the mapping keys, but the rust-axum generated server only expects the mapped type name.

Please review updates to tests and samples for examples of my use cases.

cc @linxGnu

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Contributor

@linxGnu linxGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for making the fix

@linxGnu
Copy link
Contributor

linxGnu commented Oct 25, 2025

@KevinLiddle

Test failing because:

Looks like samples/server/petstore/rust-axum/output/rust-axum-oneof/tests/oneof_with_discriminator.rs has been modified as its SHA256 `b2093528aac971193f2863a70f46eea45cf8bda79120b133a614599e80d8b46d` is not the same as the one in the record: 2d4f5a069fdcb3057bb078d5e75b3de63cd477b97725e457079df24bd2c30600

Could you please update this line with new checksum: b2093528aac971193f2863a70f46eea45cf8bda79120b133a614599e80d8b46d

@KevinLiddle
Copy link
Contributor Author

@linxGnu updated. Thanks for the quick review!

@linxGnu
Copy link
Contributor

linxGnu commented Oct 25, 2025

@wing328 PTAL. I think it's good to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants