Support chinese paths, token login, verbose debug, multithreaded download & more #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new build.py script to manage version updates from pyproject.toml. - Updated __init__.py to reflect the new versioning approach. - Enhanced README files for better clarity and formatting. - Minor adjustments in example scripts for consistency.
- Translated comments and docstrings from Chinese to English for better accessibility. - Improved logging messages in various modules to enhance clarity and consistency. - Updated version in __init__.py to 0.7.5 to reflect recent changes. - Minor adjustments in example scripts to align with updated logging and documentation.
- Simplified introduction text - Improved formatting for installation instructions - Clarified download location for files - Added examples directory with usage scripts - Updated Chinese README for consistency
- Add custom datetime parser for RFC 3339 - Mock patch to replace huggingface_hub method - Ensure compatibility with older versions
- change default version to 0.1.0 - remove allow_patterns from snapshot_download calls
- Removed allow_patterns from snapshot_download call
Removed tqdm and requests from dependencies.
HaiHui886
changed the title
- Added use_parallel option for downloads - Introduced max_workers parameter - Refactored snapshot_download for threading - Created single and multi-thread download methods
- Restore call to snapshot_download_with_single_thread - Pass max_workers to snapshot_download_with_multi_thread
- Use logger for token retrieval messages - Replace print with logger in login/logout - Update download/upload error handling to use logger - Change verbose flag to enable_parallel in download - Update snapshot_download to use logger - Replace print statements with logger in utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
This PR includes a series of enhancements for the CSGHUB CLI tool, focusing on usability, reliability, and performance during upload/download operations.
Key Improvements:
Chinese Path Handling
git config --global core.quotepath falseis set (which allows proper display of non-ASCII paths).Token & Login Management
--logincommand-line argument.--token <your_token>or by reading from the environment variable.Download Structure Improvement
csghub-cli, it now automatically creates a directory structure based on therepo_idunder the current working directory.Verbose Debug Mode
--verboseflag to help users and developers see detailed execution logs, making debugging easier.Optimized Upload Logic
nothing to commitwill be shown.Multithreaded Downloading
SDK Installation & Configuration
csghub-sdk, ensuring smoother setup and dependency resolution.Download Progress Feedback
snapshotdownto provide real-time download progress information (e.g., percentage, speed).Chinese Repository Name Check
Notes for Reviewers