Skip to content

Harfanglab incidents: propagate sighting qualification changes to existing OpenCTI sightings#6486

Closed
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-sighting-qualification-issue
Closed

Harfanglab incidents: propagate sighting qualification changes to existing OpenCTI sightings#6486
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-sighting-qualification-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 21, 2026

Sighting qualification updates from Harfanglab (e.g., changing an alert to false_positive) were not reflected in OpenCTI, leaving sightings stuck as true positive. The connector was sending bundles without update semantics, so existing sighting data was not being overwritten.

  • What changed

    • Enabled bundle updates in the Harfanglab incidents connector by passing update=True to send_stix2_bundle(...).
    • Kept ingestion behavior unchanged otherwise (same bundle content and cleanup behavior), with only update propagation added.
  • Regression coverage

    • Added a focused connector test asserting process_message() calls send_stix2_bundle with update=True, preventing regressions in sighting update behavior.
  • Key code change

    self.helper.send_stix2_bundle(
        stix_bundle,
        work_id=work_id,
        update=True,
        cleanup_inconsistent_bundle=True,
    )

Copilot AI linked an issue May 21, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix sighting qualification not updating in OpenCTI Harfanglab incidents: propagate sighting qualification changes to existing OpenCTI sightings May 21, 2026
Copilot AI requested a review from SamuelHassine May 21, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Harfanglab incident]

2 participants