Modernize settings modal and fix Electron dev install#518
Conversation
Convert settings to a dismissible overlay with grouped navigation, tighter styling, scrollable content, and streamlined stream options that infer aspect ratio from resolution while moving decoder/encoder controls into Advanced. Add ensure-electron postinstall so Electron binaries download reliably when npm install scripts are blocked. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4808e249ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (event.key === "Escape" && !nativeStreamerEnablePromptVisible) { | ||
| event.preventDefault(); | ||
| onClose(); |
There was a problem hiding this comment.
When focus is in a shortcut capture field, the existing input handler treats Escape as “cancel editing” by preventing default and blurring, but it does not stop propagation. This new window-level listener still receives that same Escape event and closes the entire settings modal, so users trying to cancel shortcut capture lose the settings dialog instead; check event.defaultPrevented or ignore Escape from editable targets before calling onClose().
Useful? React with 👍 / 👎.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…design # Conflicts: # opennow-stable/src/renderer/src/styles.css
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
1 participant
Summary
ensure-electronpostinstall and pinning Electron 42.3.3Test plan
bun installandnpm run devinopennow-stable; confirm Electron launches without the uninstall errornpm run typecheckinopennow-stable