Redirect http > https #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I ran a couple of test scenarios in Now that I'm thinking about it a bit more, that is probably because mailcatcher is not part of the HaProxy load balancing act. |
MKodde
reviewed
Jan 15, 2026
Member
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
I do not feel like the most apparent reviewer, but I did test the core and stepup environments with your new addition to the HaProxy config. And that worked really well!
See some questions/remarks below.
In order to prevent duplicate configurations, refer to the core config in stepup. `option forwarded` produced an error (haproxy would not start), so changed to `forwardfor`
johanib
force-pushed
the
feature/stepup-https-only
branch
from
41619c7 to
b957d55
Compare
Contributor
Author
|
Discussed with Pieter. Good enough to try! |
Member
|
Yes, nice fix! Here, when it seem to work, it probably does ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I lost much time tracing error messages before discovering the login flow started on http instead of https.
In order to prevent these issues in the future, ensure all requests use https. (except for the mailcatcher, which is not routed through haproxy).
In order to prevent duplicate configurations, the haproxy config from core is linked into stepup, as that specific config also has all stepup projects mapped.