Upgrade to Symfony 7.4 #136
Conversation
- Upgrade PHPstan & fix issues - Add rector (no rules applied yet) - Fix phplint cache dir
- Cleanup composer.json by removing non-existant namespaces - Apply rectors: * ThisCallOnStaticMethodToStaticCallRector * NullToStrictStringFuncCallArgRector * RemoveUselessReturnTagRector * AnnotationToAttributeRector * RenameAttributeRector - User Deprecated: Since symfony/http-kernel 6.3: Parameter "container.dumper.inline_class_loader" is deprecated, use ".container.dumper.inline_class_loader" instead.
sass-migrator division assets/scss/**/*.scss Remove warnings like during compilation: Module Warning (from ./node_modules/sass-loader/dist/cjs.js): Deprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. Recommendation: math.div(18em, 14) or calc(18em / 14)
`js-yaml` was introduced as a resolution, then kept around. It's not needed.
johanib
force-pushed
the
feature/upgrade
branch
from
8603c4c to
209c8e3
Compare
There was a problem hiding this comment.
While testing the changes in my dev environment, I found out quite some SASS parser deprecation warnings remain in the project. No blocker for me, just saying..
Also: while testing, I noticed your frontend-install modifications you made in the other projects is not included here. Leaving me with permission issues after running the frontend install task. Maybe add the following section here?
"frontend-install": [
"yarn install",
"yarn encore prod",
"./bin/console cache:clear",
"@fix-dev-permissions"
],
"fix-dev-permissions": [
"chown -R www-data:www-data /var/www/html/var/log",
"chown -R www-data:www-data /var/www/html/var/cache"
],
I'm happy to report that your changes result in a functioning demo gssp that can be used for registrations and authentications. So big up there 👍
Prior to this change, no copy-paste detection was performed as phpcpd was abanodoned. This change installs jscpd and checks the src dir.
johanib
force-pushed
the
feature/upgrade
branch
from
e289676 to
e7654bf
Compare
composer.json
Outdated
| "description": "Example Generic SAML Stepup Provider.", | ||
| "type": "project", | ||
| "minimum-stability": "stable", | ||
| "minimum-stability": "dev", |
| @@ -1,22 +1,24 @@ | |||
| @import "../../node_modules/compass-mixins"; | |||
| @include global-reset ; | |||
| @use "sass:meta"; | |||
There was a problem hiding this comment.
This change causes two build errors that I do not understand right out of the box. Please investigate
┌──> node_modules/compass-mixins/lib/compass/reset/_utilities.scss
116│ #{elements-of-type(html5-block)} {
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Thanks heaps for fixing the bulk of the deprecation warnings by the way 🐈⬛
There was a problem hiding this comment.
Nice find! Not sure why it didn't fail on my machine at first..
I removed compass-mixins, as it is pretty ancient at this point, and not sustainable to keep it.
I we used it as a global reset.
But, there already was a secondary global reset script in place 🤯
Turns out, that compass-mixins uses https://meyerweb.com/eric/tools/css/reset/ .
So I copied that in instead, which seems to work just fine.
Original:
After upgrade:
The /* html5doctor.com Reset v1.6.1 - http://cssreset.com */ reset that was included had subtle changes, such as the h2 becomming bold, and the list item icons suddenly appearing.
I think more OpenConext projects use compass-mixins, so we'll tackle that as we go along.
johanib
force-pushed
the
feature/upgrade
branch
3 times, most recently
from
28ffcf9 to
f6ecc47
Compare
The remaining ones are from `compass-mixins`
johanib
force-pushed
the
feature/upgrade
branch
from
f6ecc47 to
fe2d354
Compare
Added the fix-dev-permissions |
2 participants
No description provided.