Initialize repo as a workspace#1
Merged
jerrysxie merged 2 commits intoMay 23, 2025
Merged
Conversation
- Set up as workspace - Add storage-bus as a submodule - Update README
jerrysxie
requested review from
RobertZ2011,
dymk,
felipebalbi and
tullom
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR initializes the repository as a workspace and integrates storage-bus as a submodule while updating documentation.
- Introduces interfaces for NOR and NAND storage bus drivers.
- Sets up the workspace structure and updates Cargo.toml files.
- Revises README files to reflect the new setup.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| storage-bus/src/nor.rs | Adds enums, structs, and traits for NOR storage bus communication. |
| storage-bus/src/nand.rs | Introduces empty traits for NAND storage bus drivers. |
| storage-bus/src/lib.rs | Exposes the new storage modules. |
| storage-bus/README.md | Provides documentation for the generic storage bus interface. |
| storage-bus/Cargo.toml | Sets up package metadata for the storage-bus submodule. |
| src/main.rs & src/baremetal/mod.rs | Removes previous binary and baremetal support as part of workspace refactor. |
| README.md | Updates documentation to reflect the new MCU-agnostic focus. |
| Cargo.toml | Configures the workspace and dependency resolution. |
| .vscode/settings.json | Adjusts settings, including removal of a hardcoded target. |
Comments suppressed due to low confidence (1)
storage-bus/src/nor.rs:56
- [nitpick] Consider renaming 'cmdtype' to 'cmd_type' for improved clarity and to better follow Rust's snake_case naming convention.
pub cmdtype: Option<NorStorageCmdType>,
RobertZ2011
previously approved these changes
May 21, 2025
felipebalbi
requested changes
May 22, 2025
jerrysxie
force-pushed
the
initialize-the-repo
branch
from
cd2c5bf to
911f4cf
Compare
jerrysxie
changed the title
felipebalbi
previously approved these changes
May 22, 2025
jerrysxie
force-pushed
the
initialize-the-repo
branch
from
0c69866 to
b0c754d
Compare
tullom
approved these changes
May 22, 2025
tullom
left a comment
tullom
left a comment
There was a problem hiding this comment.
For just initializing the repo, this is good.
jeffglaum
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up as workspace
Add dummy crate as a submodule
Update README