Skip to content

Add service to implement an ACPI time-and-alarm device #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
williampMSFT wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Add service to implement an ACPI time-and-alarm device #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3bc05dc
Early implementation of ACPI time and alarm device service
williampMSFT Sep 24, 2025
020cf17
Clean up todos
williampMSFT Sep 27, 2025
f3546b6
cleanup if cruft
williampMSFT Sep 30, 2025
3685aed
cargo fmt
williampMSFT Sep 30, 2025
262d479
fix wait
williampMSFT Sep 30, 2025
fe89ac9
comments
williampMSFT Sep 30, 2025
d851bc8
put response in single buffer
williampMSFT Oct 2, 2025
6ab25d6
bitfield
williampMSFT Oct 2, 2025
1a398d4
Fix defmt build
williampMSFT Oct 2, 2025
d227646
fix arg type for storage
williampMSFT Oct 2, 2025
d8bdced
fix a couple bugs
williampMSFT Oct 3, 2025
6a5bd77
initial example service - needs more test coverage, but work is pause…
williampMSFT Oct 9, 2025
7c72f72
fix numbering of events, service ID
williampMSFT Oct 14, 2025
22f4f00
Implement GCP
williampMSFT Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ members = [
"platform-service",
"power-button-service",
"power-policy-service",
"time-alarm-service",
"type-c-service",
"debug-service",
]
Expand All @@ -34,6 +35,7 @@ bitfield = "0.17.0"
bitflags = "2.8.0"
bitvec = { version = "1.0.1", default-features = false }
block-device-driver = "0.2"
bytemuck = {version = "1.23.2", features=[ "derive" ]}
cfg-if = "1.0.0"
chrono = { version = "0.4", default-features = false }
cortex-m = "0.7.6"
Expand All @@ -54,6 +56,7 @@ embedded-hal-async = "1.0"
embedded-hal-nb = "1.0"
embedded-io = "0.6.1"
embedded-io-async = "0.6.1"
embedded-mcu-hal = { git = "https://github.com/OpenDevicePartnership/embedded-mcu" }
embedded-services = { path = "./embedded-service" }
embedded-storage = "0.3"
embedded-storage-async = "0.4.1"
Expand Down
38 changes: 0 additions & 38 deletions embedded-service/src/ec_type/generator/ec_memory_map.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,44 +39,6 @@ Capabilities:
res0:
type: u16

# Size 0x28
TimeAlarm:
events:
type: u32
capability:
type: u32
year:
type: u16
month:
type: u8
day:
type: u8
hour:
type: u8
minute:
type: u8
second:
type: u8
valid:
type: u8
daylight:
type: u8
res1:
type: u8
milli:
type: u16
time_zone:
type: u16
res2:
type: u16
alarm_status:
type: u32
ac_time_val:
type: u32
dc_time_val:
type: u32


# Size 0x64
Battery:
events:
Expand Down
22 changes: 0 additions & 22 deletions embedded-service/src/ec_type/message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,6 @@ pub enum CapabilitiesMessage {
DebugMask(u16),
}

#[allow(missing_docs)]
#[derive(Clone, Copy, Debug, PartialEq)]
pub enum TimeAlarmMessage {
Events(u32),
Capability(u32),
Year(u16),
Month(u8),
Day(u8),
Hour(u8),
Minute(u8),
Second(u8),
Valid(u8),
Daylight(u8),
Res1(u8),
Milli(u16),
TimeZone(u16),
Res2(u16),
AlarmStatus(u32),
AcTimeVal(u32),
DcTimeVal(u32),
}

#[allow(missing_docs)]
#[derive(Clone, Copy, Debug, PartialEq)]
pub enum BatteryMessage {
Expand Down
Loading