-
Notifications
You must be signed in to change notification settings - Fork 43
Indicate local vs. global in all logging #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates logging statements throughout the codebase to use Display trait implementations instead of directly accessing struct field .0, ensuring consistent formatting of port and device identifiers across both local and global port contexts.
Key changes:
- Replaced direct field access (
.0) with Display formatting for LocalPortId, GlobalPortId, and DeviceId types in log messages - Added Display trait implementation for DeviceId to support the new logging format
- Updated logging statements across multiple modules including wrapper, service, driver, and example code
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| type-c-service/src/wrapper/vdm.rs | Updated VDM event logging to use port Display format |
| type-c-service/src/wrapper/power.rs | Updated power-related logging to use port Display format |
| type-c-service/src/wrapper/pd.rs | Updated PD alert and status logging to use port Display format |
| type-c-service/src/wrapper/mod.rs | Updated controller and port status logging to use port/device Display format |
| type-c-service/src/wrapper/dp.rs | Updated DisplayPort status logging to use port Display format |
| type-c-service/src/wrapper/cfu.rs | Updated CFU device logging to use controller Display format |
| type-c-service/src/service/power.rs | Updated power service logging to use GlobalPortId Display format |
| type-c-service/src/service/mod.rs | Updated service event logging to use port Display format |
| type-c-service/src/driver/tps6699x.rs | Updated driver logging to use port Display format |
| examples/std/src/lib/type_c/mock_controller.rs | Updated mock controller logging to use port Display format |
| embedded-service/src/power/policy/mod.rs | Added Display trait implementation for DeviceId |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

No description provided.