partition-mananger: audit panics #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Panics in not deployed code, can be ignored.
jerrysxie
requested review from
JWL-surface,
Wassasin,
asasine,
bramsdell-ms,
felipebalbi and
kurtjd
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Clippy lint suppressions with explanatory comments for potentially unsafe operations in non-deployed code paths (procedural macros and code generation). The changes aim to document why certain operations that would normally trigger Clippy warnings are safe in these specific contexts.
- Adds
#[allow(clippy::unwrap_used)]attributes with safety comments in procedural macro code - Adds
#[allow(clippy::indexing_slicing)]attribute with safety comment in validation code
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| partition-manager/macros/src/lib.rs | Adds two lint suppressions for unwrap() usage in procedural macro code with explanatory comments |
| partition-manager/generation/src/lib.rs | Adds lint suppression for indexing/slicing in partition overlap validation logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kurtjd
previously approved these changes
Dec 20, 2025
kurtjd
previously approved these changes
Dec 22, 2025
Wassasin
reviewed
Dec 22, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kurtjd
approved these changes
Dec 22, 2025
madeleyneVaca
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Clippy lint suppressions and explanatory comments to improve code clarity and maintainability in non-deployed code paths. The changes focus on documenting and justifying the use of potentially unsafe operations in test or procedural macro code.
Error handling and lint suppression improvements:
#[allow(clippy::unwrap_used)]and comments explaining the safety ofunwrap()usage inpartition-manager/macros/src/lib.rs, sinceCARGO_MANIFEST_DIRis guaranteed to be set in this context and the code is not deployed.#[allow(clippy::indexing_slicing)]and comments inpartition-manager/generation/src/lib.rsto justify safe slicing and indexing in non-deployed code, preventing false-positive linter warnings.* Panics in not deployed code, can be ignored.