Exclude MCTP from panic audit #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jerrysxie
commented
Dec 22, 2025
jerrysxie
commented
- It is experimental and has not external dependencies.
* It is experimental and has not external dependencies.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR excludes the experimental MCTP (Management Component Transport Protocol) module from panic safety audits by adding clippy allow attributes. The module is not being deployed and has no external clients, making panic safety checks unnecessary at this stage.
Key Changes
- Added
#[allow(clippy::indexing_slicing)]and#[allow(clippy::unwrap_used)]attributes to the MCTP module declaration - Added blank lines around module declarations for improved readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jerrysxie
requested review from
JWL-surface,
asasine,
bramsdell-ms and
kurtjd
kurtjd
approved these changes
Dec 22, 2025
tullom
approved these changes
Dec 23, 2025
Contributor
tullom
left a comment
tullom
left a comment
There was a problem hiding this comment.
Hello from the Microsoft Taipei office!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.