Add panic lints

Cargo.toml

@@ -28,6 +28,20 @@ repository = "https://github.com/OpenDevicePartnership/embedded-services"
 [workspace.lints.rust]
 warnings = "deny"
 
+[workspace.lints.clippy]
+correctness = "deny"
+expect_used = "deny"
+indexing_slicing = "deny"
+panic = "deny"
+panic_in_result_fn = "deny"
+perf = "deny"
+suspicious = "deny"
+style = "deny"
+todo = "deny"
+unimplemented = "deny"
+unreachable = "deny"
+unwrap_used = "deny"
+
 [workspace.dependencies]
 aligned = "0.4"
 anyhow = "1.0"

debug-service/src/lib.rs

@@ -1,4 +1,8 @@
 #![no_std]
+#![allow(clippy::expect_used)]
+#![allow(clippy::indexing_slicing)]
+#![allow(clippy::unwrap_used)]
+
 mod debug_service;
 mod defmt_ring_logger;
 pub mod task;

embedded-service/src/broadcaster/immediate.rs

@@ -74,6 +74,7 @@ impl<T: Clone + 'static> Immediate<T> {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod test {
     use super::*;
     use embassy_sync::pubsub::{PubSubChannel, WaitResult};

embedded-service/src/buffer.rs

@@ -320,6 +320,7 @@ macro_rules! define_static_buffer {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod test {
     extern crate std;
     use super::*;

embedded-service/src/ec_type/mod.rs

@@ -504,6 +504,7 @@ pub fn mem_map_to_time_alarm_msg(
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
 

embedded-service/src/ec_type/protocols/mctp.rs

@@ -1341,6 +1341,7 @@ mod tests {
     }
 
     #[test]
+    #[allow(clippy::panic)]
     fn odp_header_error_on_short_buffer() {
         let header = OdpHeader {
             request_bit: false,

embedded-service/src/hid/command.rs

@@ -562,6 +562,8 @@ impl<'a> Command<'a> {
 }
 
 #[cfg(test)]
+#[allow(clippy::indexing_slicing)]
+#[allow(clippy::unwrap_used)]
 mod test {
     use super::*;
     use crate::define_static_buffer;

embedded-service/src/hid/mod.rs

@@ -350,6 +350,7 @@ pub async fn send_request(tp: &Endpoint, to: DeviceId, request: Request<'static>
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod test {
     use super::*;
 

embedded-service/src/intrusive_list.rs

@@ -414,6 +414,7 @@ mod test {
     }
 
     #[test]
+    #[allow(clippy::unwrap_used)]
     fn test_monotype_list() {
         let list_a = IntrusiveList::new();
         let list_b = IntrusiveList::new();
@@ -462,6 +463,7 @@ mod test {
     }
 
     #[test]
+    #[allow(clippy::unwrap_used)]
     fn test_multitype_list() {
         // list with multiple types within it (same registration type)
         let list_a = IntrusiveList::new();
@@ -498,6 +500,7 @@ mod test {
     }
 
     #[test]
+    #[allow(clippy::unwrap_used)]
     fn test_multi_list() {
         // nodes in multiple lists
         let list_a = IntrusiveList::new();
@@ -554,6 +557,7 @@ mod test {
     }
 
     #[test]
+    #[allow(clippy::unwrap_used)]
     fn test_multi_registration_list() {
         // list with multiple registration types
         let list = IntrusiveList::new();

embedded-service/src/ipc/deferred.rs

@@ -102,6 +102,7 @@ impl<M: RawMutex, C, R> Request<'_, M, C, R> {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use crate::GlobalRawMutex;

embedded-service/src/type_c/event.rs

@@ -517,6 +517,7 @@ impl IntoIterator for PortPending {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
 

espi-service/src/lib.rs

@@ -1,4 +1,8 @@
 #![no_std]
+#![allow(clippy::expect_used)]
+#![allow(clippy::indexing_slicing)]
+#![allow(clippy::panic)]
+#![allow(clippy::unwrap_used)]
 
 mod espi_service;
 pub mod task;

keyboard-service/Cargo.toml

@@ -36,3 +36,6 @@ log = [
     "embassy-sync/log",
     "hid-service/log",
 ]
+
+[lints]
+workspace = true

keyboard-service/src/lib.rs

@@ -5,6 +5,10 @@
 //! Otherwise, users may manually implement the `HidKeyboard` trait for custom scanning logic
 //! or hardware-implemented key scanners.
 #![no_std]
+#![allow(clippy::expect_used)]
+#![allow(clippy::indexing_slicing)]
+#![allow(clippy::panic_in_result_fn)]
+#![allow(clippy::unwrap_used)]
 
 pub mod gpio_kb;
 pub mod hid_kb;

partition-manager/generation/src/tests/mod.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::unwrap_used)]
+
 mod access;
 mod duplicate;
 mod overflow;

partition-manager/partition-manager/src/test/mod.rs

@@ -1,3 +1,6 @@
+#![allow(clippy::panic)]
+#![allow(clippy::unwrap_used)]
+
 mod mock;
 
 #[cfg(feature = "bdd")]

thermal-service/Cargo.toml

@@ -39,3 +39,6 @@ log = [
     "embassy-time/log",
     "embassy-sync/log",
 ]
+
+[lints]
+workspace = true

thermal-service/src/lib.rs

@@ -1,5 +1,7 @@
 //! Thermal service
 #![no_std]
+#![allow(clippy::todo)]
+#![allow(clippy::unwrap_used)]
 
 use embassy_sync::once_lock::OnceLock;
 use embedded_sensors_hal_async::temperature::DegreesCelsius;

type-c-service/src/lib.rs

@@ -120,6 +120,7 @@ impl PortEventStreamer {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use core::sync::atomic::AtomicBool;
 

type-c-service/src/service/config.rs

@@ -110,6 +110,7 @@ pub struct Config {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;