feat: canonical ODP wire format in mctp-rs + odp-client crate

.github/copilot-instructions.md

@@ -108,7 +108,7 @@ Services use a variety of async IPC mechanisms from `embassy-sync` and `embedded
 - **`embassy_sync::signal::Signal`** — single-value async notifications
 - **`embedded_services::ipc::deferred`** — request/response channels where the caller awaits a reply
 - **`embedded_services::broadcaster`** — publish/subscribe pattern for event fan-out
-- **`embedded_services::relay`** — relay service pattern for MCTP-based request/response dispatch with direct async calls
+- **`odp_client::server`** — relay service pattern for MCTP-based request/response dispatch with direct async calls
 
 ### Composition
 

Cargo.toml

@@ -26,6 +26,7 @@ members = [
     "debug-service-messages",
     "keyboard-service",
     "power-policy-interface",
+    "odp-client",
     "odp-service-common",
     "type-c-interface",
     "fw-update-interface",
@@ -79,6 +80,7 @@ debug-service-messages = { path = "./debug-service-messages" }
 embassy-executor = "0.10.0"
 cfu-service = { path = "./cfu-service" }
 embedded-hal-nb = "1.0"
+embedded-io = "0.7"
 embedded-io-async = "0.7.0"
 embedded-mcu-hal = "0.2.0"
 embassy-futures = "0.1.2"
@@ -97,6 +99,7 @@ fw-update-interface = { path = "./fw-update-interface" }
 fw-update-interface-mocks = { path = "./fw-update-interface-mocks" }
 mctp-rs = { path = "./mctp-rs" }
 num_enum = { version = "0.7.5", default-features = false }
+odp-client = { path = "./odp-client" }
 portable-atomic = { version = "1.11", default-features = false }
 power-policy-interface = { path = "./power-policy-interface" }
 paste = "1.0.15"

battery-service-relay/Cargo.toml

@@ -12,6 +12,7 @@ ignored = ["log"]
 defmt = { workspace = true, optional = true }
 log = { workspace = true, optional = true }
 embedded-services.workspace = true
+odp-client.workspace = true
 num_enum.workspace = true
 
 battery-service-interface.workspace = true
@@ -21,6 +22,7 @@ defmt = [
     "dep:defmt",
     "embedded-services/defmt",
     "battery-service-interface/defmt",
+    "odp-client/defmt",
 ]
 log = ["dep:log", "embedded-services/log", "battery-service-interface/log"]
 

battery-service-relay/src/lib.rs

@@ -18,14 +18,14 @@ impl<S: battery_service_interface::BatteryService> BatteryServiceRelayHandler<S>
     }
 }
 
-impl<S: battery_service_interface::BatteryService> embedded_services::relay::mctp::RelayServiceHandlerTypes
+impl<S: battery_service_interface::BatteryService> odp_client::server::RelayServiceHandlerTypes
     for BatteryServiceRelayHandler<S>
 {
     type RequestType = serialization::AcpiBatteryRequest;
     type ResultType = serialization::AcpiBatteryResult;
 }
 
-impl<S: battery_service_interface::BatteryService> embedded_services::relay::mctp::RelayServiceHandler
+impl<S: battery_service_interface::BatteryService> odp_client::server::RelayServiceHandler
     for BatteryServiceRelayHandler<S>
 {
     async fn process_request(&self, request: Self::RequestType) -> Self::ResultType {

battery-service-relay/src/serialization.rs

@@ -1,5 +1,5 @@
 use battery_service_interface::*;
-use embedded_services::relay::{MessageSerializationError, SerializableMessage};
+use odp_client::{MessageSerializationError, SerializableMessage};
 
 #[derive(num_enum::IntoPrimitive, num_enum::TryFromPrimitive, Copy, Clone, Debug, PartialEq)]
 #[repr(u16)]

debug-service-messages/Cargo.toml

@@ -9,9 +9,10 @@ repository.workspace = true
 defmt = { workspace = true, optional = true }
 embedded-services.workspace = true
 num_enum.workspace = true
+odp-client.workspace = true
 
 [lints]
 workspace = true
 
 [features]
-defmt = ["dep:defmt"]
+defmt = ["dep:defmt", "odp-client/defmt"]

debug-service-messages/src/lib.rs

@@ -1,5 +1,5 @@
 #![no_std]
-use embedded_services::relay::{MessageSerializationError, SerializableMessage};
+use odp_client::{MessageSerializationError, SerializableMessage};
 
 /// Standard Debug Service Log Buffer Size
 pub const STD_DEBUG_BUF_SIZE: usize = 128;

debug-service/Cargo.toml

@@ -16,10 +16,11 @@ debug-service-messages.workspace = true
 embassy-sync.workspace = true
 embedded-services.workspace = true
 log.workspace = true
+odp-client.workspace = true
 rtt-target = "0.6.1"
 
 [features]
-defmt = ["debug-service-messages/defmt"]
+defmt = ["debug-service-messages/defmt", "odp-client/defmt"]
 
 [lints]
 workspace = true

debug-service/src/debug_service.rs

@@ -34,12 +34,12 @@ impl Service {
     }
 }
 
-impl embedded_services::relay::mctp::RelayServiceHandlerTypes for Service {
+impl odp_client::server::RelayServiceHandlerTypes for Service {
     type RequestType = DebugRequest;
     type ResultType = DebugResult;
 }
 
-impl embedded_services::relay::mctp::RelayServiceHandler for Service {
+impl odp_client::server::RelayServiceHandler for Service {
     async fn process_request(&self, _request: Self::RequestType) -> Self::ResultType {
         // Host sent an ACPI/MCTP request (e.g. GetDebugBuffer). Treat this as the
         // trigger to send the staged debug buffer back to the host.

embedded-service/Cargo.toml

@@ -11,17 +11,11 @@ rust-version.workspace = true
 workspace = true
 
 [dependencies]
-bitfield.workspace = true
 critical-section.workspace = true
 defmt = { workspace = true, optional = true }
 embassy-sync.workspace = true
 embassy-futures.workspace = true
 log = { workspace = true, optional = true }
-paste.workspace = true
-
-[dependencies.mctp-rs]
-workspace = true
-features = ["espi"]
 
 [dependencies.serde]
 workspace = true
@@ -41,5 +35,5 @@ tokio = { workspace = true, features = ["rt", "macros", "time"] }
 
 [features]
 default = []
-defmt = ["dep:defmt", "embassy-sync/defmt", "mctp-rs/defmt"]
+defmt = ["dep:defmt", "embassy-sync/defmt"]
 log = ["dep:log", "embassy-sync/log"]

embedded-service/src/lib.rs

@@ -22,18 +22,8 @@ pub mod init;
 pub mod ipc;
 pub mod keyboard;
 pub mod named;
-pub mod relay;
 pub mod sync;
 
-/// Hidden re-exports used by macros defined in this crate.
-/// Not part of the public API — do not depend on these directly.
-#[doc(hidden)]
-pub mod _macro_internal {
-    pub use bitfield;
-    pub use mctp_rs;
-    pub use paste;
-}
-
 /// Global Mutex type, ThreadModeRawMutex is used in a microcontroller context, whereas CriticalSectionRawMutex is used
 /// in a standard context for unit testing.
 ///