Skip to content

Conversation

@berlin-with0ut-return
Copy link
Contributor

@berlin-with0ut-return berlin-with0ut-return commented Dec 10, 2025

Description

[IN DRAFT FOR CLEANUP AND TESTING]

  • Impacts functionality?
  • Impacts security?
  • [] Breaking change? Note: this doesn't directly break anything because the ACPI component is not yet enabled, but sets up the ACPI component to be enabled (additional changes needed in Patina and physical platform repos). Once the component is enabled in patina-dxe-core-qemu builds will break until all changes are integrated.
  • Includes tests?
  • Includes documentation?

How This Was Tested

Boot Q35 to shell and Windows.

Integration Instructions

  • patina-dxe-core-qemu (or platform equivalent): turn on ACPI component
  • patina-edk2: integrate new AcpiSdt split driver
  • patina-qemu (or platform equivalent): replace AcpiTableDxe with new AcpiSdt driver

Sherry Fan added 30 commits November 11, 2025 14:21
Sherry Fan and others added 7 commits December 5, 2025 15:09
## Description
The RSDP cannot be created with `AcpiTable::new()` due to its unique
header format.

Similar, we should discontinue use of `Box::new_in` and `Vec::new_in`
due to `#allocator_api` being poorly supported and unstable.

- [x] Impacts functionality? (ACPI functionality still the same. Fixes
bugs.)
- [ ] Impacts security?
- [ ] Breaking change?
- [x] Includes tests?
- [ ] Includes documentation?

## How This Was Tested
Boot on QEMU to Windows.

## Integration Instructions
N/A.

---------

Co-authored-by: Sherry Fan <[email protected]>
@github-actions github-actions bot added the impact:testing Affects testing label Dec 10, 2025
@berlin-with0ut-return berlin-with0ut-return changed the base branch from main to feature/acpi December 10, 2025 00:27
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/patina_acpi/src/component.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:testing Affects testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant