-
Notifications
You must be signed in to change notification settings - Fork 39
[DRAFT] Implement AcpiGet (to enable custom ACPI SDT protocol split)
#1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
berlin-with0ut-return
wants to merge
39
commits into
OpenDevicePartnership:feature/acpi
Choose a base branch
from
berlin-with0ut-return:acpi_integration
base: feature/acpi
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DRAFT] Implement AcpiGet (to enable custom ACPI SDT protocol split)
#1179
berlin-with0ut-return
wants to merge
39
commits into
OpenDevicePartnership:feature/acpi
from
berlin-with0ut-return:acpi_integration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into acpi_integration
…into acpi_integration
…into acpi_integration
…into acpi_integration
…ip/patina into acpi_integration
…ip/patina into acpi_integration
## Description The RSDP cannot be created with `AcpiTable::new()` due to its unique header format. Similar, we should discontinue use of `Box::new_in` and `Vec::new_in` due to `#allocator_api` being poorly supported and unstable. - [x] Impacts functionality? (ACPI functionality still the same. Fixes bugs.) - [ ] Impacts security? - [ ] Breaking change? - [x] Includes tests? - [ ] Includes documentation? ## How This Was Tested Boot on QEMU to Windows. ## Integration Instructions N/A. --------- Co-authored-by: Sherry Fan <[email protected]>
…into acpi_integration
…ip/patina into acpi_integration
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
c9f2734 to
b77d29f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[IN DRAFT FOR CLEANUP AND TESTING]
How This Was Tested
Boot Q35 to shell and Windows.
Integration Instructions