patina_dxe_core: Additional cleanup of image.rs #1192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
I will work on unit tests today. But please feel free to review. It is a non-functional change, just doing some re-organization. |
os-d
approved these changes
Dec 15, 2025
joschock
reviewed
Dec 15, 2025
Contributor
joschock
left a comment
joschock
left a comment
There was a problem hiding this comment.
Added several comments, acknowledging that a subset of them note pre-existing issues.
joschock
reviewed
Dec 16, 2025
joschock
reviewed
Dec 16, 2025
Javagedes
force-pushed
the
personal/joeyvagedes/image-updates-round-2
branch
4 times, most recently
from
49891c1 to
3751c90
Compare
vineelko
approved these changes
Dec 29, 2025
This commit performs some additional non-functional cleanup of image.rs to break up the larger functions into smaller chunks that only perform one operation each. This makes understanding and testing the code simpler.
…ath as the filename, per PR review
Javagedes
force-pushed
the
personal/joeyvagedes/image-updates-round-2
branch
from
3751c90 to
17d6e32
Compare
vineelko
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit performs some additional non-functional cleanup of image.rs to break up the larger functions into smaller chunks that only perform one operation each. This makes understanding and testing the code simpler.
How This Was Tested
CI, Boots to shell.
Integration Instructions
N/A