patina_boot: Add patina_boot crate #1201
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
| @@ -0,0 +1,311 @@ | |||
| //! Library functions for boot orchestration. | |||
There was a problem hiding this comment.
nit: Not a big fan of calling this module "library" considering it is a sub-module of "lib.rs". I don't really have a suggestion for a better module name but would ask that it is updated.
| repository.workspace = true | ||
| license.workspace = true | ||
| edition.workspace = true | ||
| description = "Boot orchestration components for Patina firmware." |
There was a problem hiding this comment.
Please add a readme file, even if it is basically empty :)
| /// 4. Signal ReadyToBoot | ||
| /// 5. Execute boot options from config | ||
| /// 6. If all boot options fail, call failure handler | ||
| fn entry_point( |
There was a problem hiding this comment.
From the looks of this, this will be triggered immediately, well before you are ready, as there is no function parameter that is not immediately available. You will need something to signal that this component should be executed.
Additionally, How does this interact with call_bds ? and the BDS protocol? Might be a conversation for the RFC.
There was a problem hiding this comment.
Added this topic to "Unresolved Questions" section, to open discussion: https://github.com/kat-perez/patina/blob/rfc-boot-manager/docs/src/rfc/text/0000-patina-boot.md#unresolved-questions
kat-perez
force-pushed
the
feature/patina-boot
branch
from
2120b39 to
816b626
Compare
kat-perez
force-pushed
the
feature/patina-boot
branch
from
816b626 to
5218d9b
Compare
2 participants
Description
(This is still WIP, so review at your own discretion)
Adds BootOrchestration component, simple console discovery, simple BootOption Config
How This Was Tested
QEMU Platform Integration:
Integration Instructions
N/A