Skip to content

rust-toolchain: Update nightly toolchain (1.95.0) [Rebase & FF]#1528

Open
makubacki wants to merge 2 commits into
OpenDevicePartnership:mainfrom
makubacki:update_rust_1_95
Open

rust-toolchain: Update nightly toolchain (1.95.0) [Rebase & FF]#1528
makubacki wants to merge 2 commits into
OpenDevicePartnership:mainfrom
makubacki:update_rust_1_95

Conversation

@makubacki
Copy link
Copy Markdown
Collaborator

@makubacki makubacki commented May 26, 2026

Description

Closes #1519

The previous nightly toolchain was from 2026-02-13, which had partial support for some of the changes that ended up in Rust 1.95.0. This updates the toolchain to the same day the 1.95.0 stable tag was created.

Also fixes clippy issues reported after the update.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

  • cargo make all with the updated toolchain

Integration Instructions

  • N/A

@makubacki makubacki requested review from a team, Javagedes, cfernald, os-d and vineelko May 26, 2026 18:31
@makubacki makubacki self-assigned this May 26, 2026
@patina-automation
Copy link
Copy Markdown
Contributor

patina-automation Bot commented May 26, 2026

⌛ QEMU Validation Pending

QEMU validation is pending on successful CI completion.

Note: Any previous results are available in this comment's edit history.

This comment was automatically generated by the Patina QEMU PR Validation workflow.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
patina_dxe_core/src/allocator.rs 50.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Comment thread rust-toolchain.toml
@antklein antklein requested a review from Copilot May 26, 2026 20:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR performs a small Rust toolchain bump and includes a handful of code cleanups (mostly iterator/match simplifications) plus minor test adjustments.

Changes:

  • Bump the pinned Rust nightly toolchain version.
  • Simplify iteration patterns (values() instead of destructuring keys; remove redundant into_iter() usage).
  • Refactor match arms to use guards for clearer conditional execution.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/patina_ffs/src/volume.rs Test loop iteration simplified by relying on IntoIterator for the second zipped collection.
rust-toolchain.toml Updates the pinned nightly toolchain date/version.
patina_dxe_core/src/protocol_db.rs Uses values() to avoid unnecessary key destructuring when collecting registered protocols.
patina_dxe_core/src/allocator/fixed_size_block_allocator.rs Test computation uses allocated_address directly (removing an explicit cast).
patina_dxe_core/src/allocator.rs Uses match guards (if res.is_ok()) to reduce nesting around MAT installation.

@makubacki
Copy link
Copy Markdown
Collaborator Author

Fyi, I'm going to override the test coverage requirement for this since two lines are missing in allocator.rs that are unrelated to the change. Adding tests would also complicate merging other more meaningful work-in-progress in allocator.

@makubacki
Copy link
Copy Markdown
Collaborator Author

Also, since this is bumping the Rust toolchain (although not by much), I will leave it open for a few days for feedback per the update process.

makubacki added 2 commits May 27, 2026 19:35
The previous nightly toolchain was from 2026-02-13, which had partial
support for some of the changes that ended up in Rust 1.95.0. This
updates the toolchain to the same day the 1.95.0 stable tag was
created.

Also fixes clippy issues reported after the update.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Simplifies the info for Rust version updates in the main readme and
adds a new page to the mdbook with more detail. Covers nightly
version selection, cadence, and review process.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki changed the title rust-toolchain: Update nightly toolchain (1.95.0) rust-toolchain: Update nightly toolchain (1.95.0) [Rebase & FF] May 28, 2026
@github-actions github-actions Bot added the type:documentation Improvements or additions to documentation label May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rust 1.95 tracking issue

7 participants