rust-toolchain: Update nightly toolchain (1.95.0) [Rebase & FF]#1528
rust-toolchain: Update nightly toolchain (1.95.0) [Rebase & FF]#1528makubacki wants to merge 2 commits into
Conversation
⌛ QEMU Validation PendingQEMU validation is pending on successful CI completion.
This comment was automatically generated by the Patina QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR performs a small Rust toolchain bump and includes a handful of code cleanups (mostly iterator/match simplifications) plus minor test adjustments.
Changes:
- Bump the pinned Rust nightly toolchain version.
- Simplify iteration patterns (
values()instead of destructuring keys; remove redundantinto_iter()usage). - Refactor
matcharms to use guards for clearer conditional execution.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/patina_ffs/src/volume.rs | Test loop iteration simplified by relying on IntoIterator for the second zipped collection. |
| rust-toolchain.toml | Updates the pinned nightly toolchain date/version. |
| patina_dxe_core/src/protocol_db.rs | Uses values() to avoid unnecessary key destructuring when collecting registered protocols. |
| patina_dxe_core/src/allocator/fixed_size_block_allocator.rs | Test computation uses allocated_address directly (removing an explicit cast). |
| patina_dxe_core/src/allocator.rs | Uses match guards (if res.is_ok()) to reduce nesting around MAT installation. |
|
Fyi, I'm going to override the test coverage requirement for this since two lines are missing in allocator.rs that are unrelated to the change. Adding tests would also complicate merging other more meaningful work-in-progress in allocator. |
|
Also, since this is bumping the Rust toolchain (although not by much), I will leave it open for a few days for feedback per the update process. |
The previous nightly toolchain was from 2026-02-13, which had partial support for some of the changes that ended up in Rust 1.95.0. This updates the toolchain to the same day the 1.95.0 stable tag was created. Also fixes clippy issues reported after the update. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Simplifies the info for Rust version updates in the main readme and adds a new page to the mdbook with more detail. Covers nightly version selection, cadence, and review process. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
8423e44 to
ed6dee4
Compare
Description
Closes #1519
The previous nightly toolchain was from 2026-02-13, which had partial support for some of the changes that ended up in Rust 1.95.0. This updates the toolchain to the same day the 1.95.0 stable tag was created.
Also fixes clippy issues reported after the update.
How This Was Tested
cargo make allwith the updated toolchainIntegration Instructions