Fix Juneteenth observance for US calendars#2786
Open
LarryHu0217 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2726.
Summary
Make Juneteenth use the existing
bumpBacksetting in the common US holiday-calendar generator, matching the handling already used for Independence Day and Christmas.When Juneteenth falls on Saturday:
bumpBackis enabled.bumpBackis disabled.The regression test covers all four calendars for Friday, June 18, 2027.
Validation
mvn -pl modules/basics -am -Dtest=GlobalHolidayCalendarsTest -Dsurefire.failIfNoSpecifiedTests=false test- 405 tests passedmvn -pl modules/basics -am test- 5,814 tests passedgit diff --check