Fix Legend Panel Bug & Style#424
Open
annehaley wants to merge 3 commits into
Open
Conversation
Deploying geodatalytics with
|
| Latest commit: |
556123b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://92e1702c.geodatalytics.pages.dev |
| Branch Preview URL: | https://fix-legend.geodatalytics.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was writing the documentation for the legend panel, I found this bug. If two copies of the same layer are added to the map, the eye icon for one copy will toggle the visibility of both copies. We had two slightly different
setVisibilityfunctions, one for the selected layers panel and one for the legend panel. To resolve the bug I consolidated the logic in a newlayerStorefunction,setLayerVisibility. Both panels now use the same function to toggle layer visibility.Edit: I also found a few more things to fix: