Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause and unpause music #3039

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

LeeSpork
Copy link
Contributor

@LeeSpork LeeSpork commented Mar 21, 2025

After pausing and then unpausing the game, the background music will now resume playing from where it left off, matching original behaviour.

Closes #3038

@LeeSpork
Copy link
Contributor Author

LeeSpork commented Mar 21, 2025

It can be discussed in future issues whether other audio should also use the channel pausing feature implemented here. (Though if so: may want to check all uses of Channel::isPlaying() to prevent any potential bugs – it perhaps might make sense to just entirely replace that method with a isPlayingOrPaused method?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Song changes when game paused
1 participant