fix: remove torch dependency from ONNX runtime - #84
Open
z2z23n0 wants to merge 1 commit into
Open
Conversation
z2z23n0
marked this pull request as ready for review
June 30, 2026 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch/torchaudiousage inonnx_tts_runtime.pywithsoundfile+ NumPy(1, channels, samples)soundfile>=0.12.0topyproject.tomlbecause the ONNX runtime now imports it directlyCloses #73.
Root Cause
The ONNX runtime path still imported PyTorch because reference-audio loading used
torchaudio.load,torch.float32, andtorchaudio.functional.resample. That meantapp_onnx.pycould fail at import time in lightweight ONNX-only environments without PyTorch installed.Validation
numpy soundfile sentencepiece onnxruntimetorch_available=Falseandtorchaudio_available=Falseimport onnx_tts_runtimesucceeds without PyTorch installed_load_reference_audio()loads a temporary mono WAV, resamples it, duplicates channels, and returns float32 shape(1, 2, 4000)python -m py_compile onnx_tts_runtime.pygit diff --check