Conversation
arcticfly
approved these changes
Feb 12, 2026
Collaborator
arcticfly
left a comment
There was a problem hiding this comment.
Thanks. Do you want me to update the notebooks as well, or are you already working on that?
Collaborator
Author
|
@arcticfly if you can that would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model.nametomodel.get_inference_name()across examples/dev scripts/docs@step@stepsuffixesWhy
Recent behavior allowed unsuffixed
model.nameto silently route to stale step-0 adapters in some backends. This change makes incorrect usage fail loudly and standardizes explicitmodel@stepinference routing.Validation
uv run --extra backend pytest tests/integration/test_multi_checkpoint_training.py::test_local_backend -quv run --extra tinker pytest tests/integration/test_tinker_native_backend.py -quv run pytest tests/unit/test_multi_checkpoint_inference.py -q -k "served_model_name_uses_base_model_when_lora_enabled or TestStepParsing"