Nhse o40 orkv.i141 silvermachine - #144
Open
martinsumner wants to merge 36 commits into
Open
Conversation
Ready to start again with the SilverMachine handler mochijson2 is still available (due to rhc). mochihex temporarily reinstated due to tictac aae console
With basic unit tests - end-to-end testing WIP
Testing is WIP
Add routing tests
Now passes all group 2i_all
WIP to add If-Match back into HTTP (was handled in WebMachine decision_core)
Previously check was in webmachine, so needs to be added into riak_kv now.
Should return multipart/mixed only if tis is preferred
Needless incompatibility with 3.4.1 with minimal gain in value
CRDT module not yet tested, other than basic test within http_bucket_types
Note that X-Riak-ClientId header is ignored, as it is now (unless there are nodes in the cluster < v 1.0).
martinsumner
marked this pull request as ready for review
May 1, 2026 11:14
WarpEngineer
approved these changes
May 22, 2026
WarpEngineer
left a comment
WarpEngineer
left a comment
Member
There was a problem hiding this comment.
I tried to find a problem but the logic seem sound here. It's a very large PR so possible I missed something. We'll need a good bit of testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the HTTP aPI to use SilverMachine (within riak_api) not mochiweb/webmachine.
See OpenRiak/riak_api#3