-
Notifications
You must be signed in to change notification settings - Fork 22
Cel rebase #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jeremi
wants to merge
9
commits into
17.0
Choose a base branch
from
cel-rebase
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Cel rebase #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… modules Add CEL (Common Expression Language) domain filter system and metrics/indicators framework with renamed module prefixes: - spp_cel_domain: CEL expression parsing, translation, and execution - spp_cel_registry_search: CEL-based registry search wizards - spp_indicators: Metrics framework (renamed from openspp_metrics) - spp_indicators_demo: Demo providers - spp_indicators_ui: UI components for metrics All modules pass pre-commit hooks with proper code quality fixes: - Type annotations modernized (PEP 604) - Exception handling with proper chaining - Strict parameter for zip operations - Line length compliance - Variable naming clarity
Update @tagged decorators in test files to use the correct module name 'spp_indicators' instead of the old 'openspp_metrics' name. This fixes 404 errors when running HTTP endpoint tests.
…ice, resolvers, providers, wizards, views, controllers); update UI and CEL domain references; rename feature store table to openspp_indicator_value; update tests
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 17.0 #856 +/- ##
==========================================
+ Coverage 79.73% 79.76% +0.02%
==========================================
Files 791 869 +78
Lines 20980 25791 +4811
Branches 2466 3200 +734
==========================================
+ Hits 16729 20572 +3843
- Misses 3674 4364 +690
- Partials 577 855 +278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Why is this change needed?
How was the change implemented?
New unit tests
Unit tests executed by the author
How to test manually
Related links