Skip to content

Conversation

@jeremi
Copy link
Member

@jeremi jeremi commented Oct 10, 2025

Why is this change needed?

How was the change implemented?

New unit tests

Unit tests executed by the author

How to test manually

Related links

jeremi and others added 9 commits October 9, 2025 13:53
… modules

Add CEL (Common Expression Language) domain filter system and metrics/indicators
framework with renamed module prefixes:
- spp_cel_domain: CEL expression parsing, translation, and execution
- spp_cel_registry_search: CEL-based registry search wizards
- spp_indicators: Metrics framework (renamed from openspp_metrics)
- spp_indicators_demo: Demo providers
- spp_indicators_ui: UI components for metrics

All modules pass pre-commit hooks with proper code quality fixes:
- Type annotations modernized (PEP 604)
- Exception handling with proper chaining
- Strict parameter for zip operations
- Line length compliance
- Variable naming clarity
Update @tagged decorators in test files to use the correct module name
'spp_indicators' instead of the old 'openspp_metrics' name. This fixes
404 errors when running HTTP endpoint tests.
…ice, resolvers, providers, wizards, views, controllers); update UI and CEL domain references; rename feature store table to openspp_indicator_value; update tests
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 79.96259% with 964 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.76%. Comparing base (ae1ae36) to head (84c9922).

Files with missing lines Patch % Lines
spp_cel_domain/models/cel_translator.py 61.40% 141 Missing and 89 partials ⚠️
spp_cel_domain/models/cel_executor.py 76.92% 66 Missing and 51 partials ⚠️
spp_indicators/controllers/main.py 72.34% 41 Missing and 24 partials ⚠️
spp_indicators/models/service.py 77.11% 28 Missing and 18 partials ⚠️
spp_cel_domain/models/cel_registry.py 64.28% 28 Missing and 7 partials ⚠️
spp_indicators/models/feature_store.py 75.18% 26 Missing and 7 partials ⚠️
spp_indicators/wizard/invalidate_wizard.py 35.55% 29 Missing ⚠️
spp_indicators/wizard/prefetch_wizard.py 50.87% 25 Missing and 3 partials ⚠️
spp_indicators_ui/models/feature_value.py 22.22% 28 Missing ⚠️
spp_cel_domain/wizard/cel_rule_wizard.py 75.22% 19 Missing and 8 partials ⚠️
... and 31 more
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #856      +/-   ##
==========================================
+ Coverage   79.73%   79.76%   +0.02%     
==========================================
  Files         791      869      +78     
  Lines       20980    25791    +4811     
  Branches     2466     3200     +734     
==========================================
+ Hits        16729    20572    +3843     
- Misses       3674     4364     +690     
- Partials      577      855     +278     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants