fix: Serial now outputs CRLF rather than just LF for better compatibility#353
Merged
hhvrc merged 3 commits intoOpenShock:developfrom Apr 13, 2025
Merged
fix: Serial now outputs CRLF rather than just LF for better compatibility#353hhvrc merged 3 commits intoOpenShock:developfrom
hhvrc merged 3 commits intoOpenShock:developfrom
Conversation
🦋 Changeset detectedLatest commit: f4f3e88 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hhvrc
requested changes
Apr 9, 2025
Contributor
hhvrc
left a comment
hhvrc
left a comment
There was a problem hiding this comment.
Seems like not all the newline cases have been touched, also try to keep the calls down if possible, but thats just a nitpick
(please indicate if this should be squashed)
hhvrc
approved these changes
Apr 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the (built-in) calls to Serial to now output CRLF rather than just LF for better compatibility with bare Unix terminals.
Serial.printlnalso does this, so it is the expected behaviour according to the Serial library.Context is on Discord in the development channel (https://discord.com/channels/1078124408775901204/1159546859732348949/1359618488796319775)
Workarounds include
-m INLCRNLto tio orsudo stty -F /dev/ttyACM0 inlcr.This was tested on my personal board (which includes some other commits not present here).
The testing was not necessarily exhaustive and it is possible I missed some commands.
The buffer reserve changes were not checked (why is help buffered...?) but this isn't critical to functioning.
This may add more conflicts on some other existing PRs such as #319.