Skip to content

Sort for candidates - #6447

Open
Elblinator wants to merge 6 commits into
OpenSlides:mainfrom
Elblinator:5391-candidate-sort-buttons
Open

Sort for candidates#6447
Elblinator wants to merge 6 commits into
OpenSlides:mainfrom
Elblinator:5391-candidate-sort-buttons

Conversation

@Elblinator

@Elblinator Elblinator commented Jul 28, 2026

Copy link
Copy Markdown
Member

resolves #5391
resolves #6160

Additionally I added the number behind the assignment-list this was a wish from @emanuelschuetze

@xela1601, I used your implementation but changed some functionality, added some features
and added three different variants of the visuals.
We will decide which visuals to use and then I'll remove accordingly

@Elblinator Elblinator added this to the 4.4 milestone Jul 28, 2026
@Elblinator Elblinator self-assigned this Jul 28, 2026
@Elblinator Elblinator assigned bastianjoel and MSoeb and unassigned Elblinator Jul 28, 2026
@Elblinator
Elblinator requested review from MSoeb and bastianjoel July 28, 2026 13:33
@Elblinator
Elblinator marked this pull request as ready for review July 28, 2026 13:33

@MSoeb MSoeb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting works fine and fast. Two points needs to be changed.

  1. Small ranking improvement needed: If the candidate list contains of accounts that only have a first name or a last name, the sorting doesn't work properly.

Example - sorting by first name:
Image

First account 'executive board' is only a last name and it will be ranked on top position. That is wrong. The account 'executive board' should be at last position. - This problem also occurs if an account has only a first name and the sorting is done by last name. In this case, the account with only a first name should also appear on the last position.

  1. Add sort button instead of separted buttons. Options should be first name and last name. If sorting is active highlight the word sort. No active sorting, the word sort should not be highlighted.

@Elblinator
Elblinator requested a review from MSoeb July 30, 2026 13:08
@Elblinator Elblinator assigned bastianjoel and MSoeb and unassigned Elblinator Jul 30, 2026

@MSoeb MSoeb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice :)

@MSoeb MSoeb assigned Elblinator and unassigned MSoeb Jul 30, 2026
@Elblinator Elblinator removed their assignment Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable sorting candidates by first/last name

3 participants