Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cleanups to C++-ify the code:
std::vector<Sample>
instead ofstd::vector<Sample *>
. Samples pointers are not stored anywhere else so there's no worry about its location changing if the vector is reallocated. This simplifies clean up as no pointers need to be deleted.std::vector<uint8_t>
instead of a raw pointer allocated withmalloc()
. This avoids needing to manuallyfree()
during clean up.typedef std::string string
in favour of just usingstd::string
everywhere, and useconst std::string &
when we're passing an existing string without making a copy.cstdint
, instead of defininguintX_t
on Windows.