Fix wording around AD/AAD #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "authenticated data" sounds ambiguous and doesn't match definitions from either NIST standard - "additional authenticated data (AAD)" or RFC 5116 - "The associated data is authenticated but not encrypted". Moreover, specifying payload as a part of AD/AAD is plain wrong. Fix by using the term from AEAD RFC (associated data) and removing the payload from its definition. Signed-off-by: Lev Stipakov <[email protected]>
|
I don't quite agree. Your own text says that "The associated data is authenticated but not encrypted", so calling it authenticated is correct.
Why? The data we are authenticating (headers) is part of the on wire payload. |
|
The confusion sparks from the fact that the word "authenticated" is used both as "authenticated via crypto" (i.e. included in the tag computation) but also as "part of the AAD". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "authenticated data" sounds ambiguous and doesn't match definitions from either NIST standard - "additional authenticated data (AAD)" or RFC 5116 - "The associated data is authenticated but not encrypted". Moreover, specifying payload as a part of AD/AAD is plain wrong.
Fix by using the term from AEAD RFC (associated data) and removing the payload from its definition.