fix: CUDA and Vulkan binary download failures on Windows#379
Merged
gabrielste1n merged 3 commits intoOpenWhispr:mainfrom Mar 11, 2026
Merged
fix: CUDA and Vulkan binary download failures on Windows#379gabrielste1n merged 3 commits intoOpenWhispr:mainfrom
gabrielste1n merged 3 commits intoOpenWhispr:mainfrom
Conversation
- Replace PowerShell Expand-Archive with tar.exe for zip extraction (fallback to Expand-Archive if tar unavailable). Fixes systems where Microsoft.PowerShell.Archive module fails to load. - Add recursive file search (_findFile/_findFiles) in CUDA manager to handle nested archive structures, matching LlamaVulkanManager pattern. - Add concurrent download guard (_downloading flag) to prevent parallel CUDA downloads from multiple UI clicks. - Restart whisper-server after CUDA download/delete so the correct binary is used without requiring app restart. - Restart llama-server after Vulkan download so GPU acceleration activates immediately. - Add error logging for CUDA and Vulkan download failures. - Expose downloading state in CUDA status IPC response. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tion and ordering - Move tar→PowerShell fallback extraction and recursive file search into downloadUtils.js to eliminate duplication across whisperCudaManager and llamaVulkanManager - Convert sync readdirSync file search to async fsPromises.readdir - Add isDownloading() getter to WhisperCudaManager instead of exposing _downloading directly - Fix Vulkan download handler to persist env file before restarting server
gabrielste1n
approved these changes
Mar 11, 2026
Collaborator
|
thank you sir @egsok !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CUDA and Vulkan GPU acceleration binaries failing to download/activate on Windows systems where the PowerShell
Microsoft.PowerShell.Archivemodule cannot load.Root cause:
Expand-Archiverelies onMicrosoft.PowerShell.Archivewhich fails to auto-load on some Windows configurations, silently breaking all zip extraction in bothWhisperCudaManagerandLlamaVulkanManager.Additional issues fixed:
Changes
src/helpers/whisperCudaManager.jsExpand-Archivewithtar.exe(built into Windows 10+), falling back to PowerShell if tar is unavailable_findFile()/_findFiles()for binary search in extracted archives (matches existingLlamaVulkanManagerpattern)_downloadingflag to prevent concurrent downloadstry/finallyso the download flag resets on any errorsrc/helpers/llamaVulkanManager.jsExpand-Archivewithtar.exe+ PowerShell fallback (same fix)src/helpers/ipcHandlers.jsdownloadingstate to CUDA status IPC responseTest plan
🤖 Generated with Claude Code