Add Gemini 3.5 Flash to Google Gemini models#837
Conversation
Fork PRs lack the AZURE_* secrets, so electron-builder's azureSignOptions make the build-windows "Build and Sign Application" step fail. The macOS job already skips signing on pull_request via CSC_IDENTITY_AUTO_DISCOVERY; apply the same guard to the Windows job. The previous dependabot-only carve-out is subsumed since dependabot PRs are pull_request events. Signing on push/release is unchanged.
|
Heads-up: I bundled a small CI fix into this PR (one line in
I changed the Windows step to skip Azure signing for all Happy to split this into a separate PR if you'd prefer — just let me know. The Gemini 3.5 Flash change itself is unrelated and builds fine on macOS/Linux. |
|
Follow-up on the Windows CI fix: the previous inline override, Local checks passed after rebase: |
|
Also waiting:
|
|
Nice addition, the model entry plus the thinking-suppression wiring is mostly there. One thing blocks it for me. In Per Google's docs the Pro tier only accepts The other two paths you touched already gate on if (config.disableThinking === true && getCloudModel(model)?.supportsThinking) {Then only 3.5 Flash gets Smaller one: the |
|
Thanks for the review — I pushed
Validation passed:
All recommendations from the review comment are implemented. |
|
Both addressed, thanks for the quick turnaround. |
gabrielste1n
left a comment
There was a problem hiding this comment.
awesome work thank you @KachurPro
…ispr#837 Reconcile feat/gemma-4-thinking-level with upstream OpenWhispr#837 (Gemini 3.5 Flash + Gemini thinking-disable rework), which touched the same Gemini logic. - Extract resolveGeminiThinkingConfig() (src/services/ai/geminiThinking.ts), shared by the native REST cleanup path (gemini.ts) and the AI-SDK agent path (ReasoningService.ts): Gemma 4 maps the "Disable thinking" toggle two-way (minimal/high); supportsThinking-only models (e.g. Gemini 3.5 Flash) drop to minimal when disabled, matching OpenWhispr#837. Always sets includeThoughts:false. - gemini.ts: keep the `??` temperature fix and the multi-part thought-filtering parser; adopt OpenWhispr#837's GeminiGenerationConfig interface. - ReasoningService.ts: honor the thinking level in agent/tools mode too, closing the gap where the Minimal/High selector only affected the cleanup path. - Add unit tests for the mapping (test/services/geminiThinking.test.js). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Summary
reasoning_effort: "none"to Gemini pathsWhy
Gemini 3.5 Flash was released in May 2026 and has been performing especially well in OpenWhispr-style workflows: very fast interactive cleanup, strong instruction following for context cleanup, and reliable team-agent control.
It is a strong recommended focus model for users who want a fast cloud model for language cleanup and agent workflows.
Validation
npm run i18n:checknpm run typechecknpm run lint(passes with existing warnings, no errors)npm run build:renderermodels/gemini-3.5-flashis available via ListModels and supportsgenerateContent; direct Gemini and OpenAI-compatible smoke requests returned OK