ci(release): adopt npm OIDC trusted publishing#658
Draft
0xisk wants to merge 1 commit into
Draft
Conversation
Drop NPM_TOKEN/NODE_AUTH_TOKEN and let npm mint short-lived, repo-scoped credentials per run via the OIDC id-token (id-token: write was already set), with provenance. Ensure npm >= 11.5.1, which trusted publishing requires. Requires the package to be registered as a Trusted Publisher for this repo + workflow on npmjs.org; publishing fails until that is configured. Closes #560.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switches npm publishing to OIDC trusted publishing — no
NPM_TOKEN.NODE_AUTH_TOKEN/NPM_TOKENfrom the publish step; npm mints short-lived, repo-scoped credentials per run via the OIDCid-token(id-token: writewas already set).npm install -g npm@latest) — trusted publishing requires it, and the.nvmrcNode may bundle an older npm.NPM_CONFIG_PROVENANCE: true).Result: no standing npm secret to rotate, no token expiry/scope failures, provenance on npm.
Notes
release.ymlbut in different regions (job-level gate vs. publish-step auth), so they merge cleanly in either order.OpenZeppelin/openzeppelin-ui/.github/workflows/publish.yml.Closes #560.