test(crypto): keep mock circuits impure for live - #850
Draft
0xisk wants to merge 1 commit into
Draft
Conversation
A mock whose circuits touch neither ledger nor witness has all of them promoted to pure by the compiler, so the artifact ships no keys/ and no zkir/ and the code is only ever evaluated in JS. The crypto specs then pass identically on the live backend without proving anything. An `_invocations` counter in each mock forces impurity, so every circuit gets a proving key and a real proof on live. The specs move to simulators to reach them. The EcdhMask round-trip property drops to 3 runs on live: 100 runs is 200 transactions, well past the unit-live per-test timeout.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Same technique already applied to
MockEcdsain #842.Not visible in the diff:
keys/orzkir/and the specs passed onunit-livewithout proving anything. The_invocationscounter is the only lever that forces impurity. Nothing was kept pure: none of these circuits is an oracle recomputing an expected value.ledger()reader.getPublicState()is still{}and the simulator ledger types are unchanged.live-testslabel or a workflow dispatch.PR Checklist