Backport v1.0.0 delayed fix

[ericnordelo]

Summary by CodeRabbit

• API Changes

  • Updated delayed transfer wrap function to accept a recipient address parameter and transfer the wrapper directly to the recipient instead of returning it to the caller.

• Documentation

  • Updated delayed transfer documentation to reflect the new function signature and ownership transfer flow.

• Chores

  • Added published version metadata for mainnet environments.
  • Updated audit reference links to use new directory naming conventions.

[coderabbitai]

Walkthrough

This pull request updates the delayed transfer API to require an explicit recipient parameter in the wrap function, transferring the wrapper directly to that recipient instead of returning it. Corresponding test infrastructure is refactored from manual TxContext handling to test_scenario pattern, and documentation is updated accordingly. Auto-generated published metadata files are added for two modules.

Changes

Cohort / File(s)	Summary
Delayed Transfer API contracts/access/sources/ownership_transfer/delayed.move	wrap function signature changed to accept recipient: address parameter and transfer the wrapper to that address instead of returning DelayedTransferWrapper<T>; WrapExecuted event updated to report recipient as owner instead of ctx.sender().
Test Infrastructure Refactoring contracts/access/tests/delayed_tests.move	Migrated test framework from manual TxContext construction to test_scenario workflow; removed dummy_ctx_with_sender helper; replaced mutable context operations with test_scenario::begin(), test.ctx(), test.next_tx(), and test.take_from_sender() patterns throughout test suite.
Documentation Updates CHANGELOG.md, contracts/access/README.md	Updated documentation to reflect new wrap function signature, ownership flow, and event emissions in delayed transfer module.
Published Metadata contracts/access/Published.toml, math/core/Published.toml	Auto-generated published version metadata files for mainnet containing chain-id, published-at, original-id, version, toolchain-version, build-config, and upgrade-capability.
Audit Directory References audits/README.md	Updated link targets to use 2026-03 directory naming instead of 2026-3 in two rows (v1.0.0 and PR183 entries).
Math Test Optimization math/core/tests/macros/math_ops.move	Replaced 512-bit division helper (u512::div_rem_u256) with direct u256-space arithmetic for computing baseline and remainder values in mul_div_wide test cases.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Backport release v1.0.0 to main #211: Directly modifies wrap function in the same file to return DelayedTransferWrapper<T>, while this PR alters the same function to accept recipient and transfer the wrapper—opposite directional changes to the same API.
• ref: ownership transfer wrappers #47: Introduces the initial DelayedTransferWrapper and wrap implementation; this PR significantly alters that API to change ownership transfer semantics.
• ref: naming and receiver syntax #123: Also modifies delayed transfer wrapper API and related test patterns, affecting wrapper operations and custody transfer logic.

Suggested reviewers

• 0xNeshi
• immrsd
• bidzyyys

---

🐰 A wrapper finds its home with care,
No longer waiting in the air,
Direct to recipient it goes,
While tests now dance through scenarios,
A cleaner flow, the code now knows! 🎀

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author, missing required sections like context, purpose, and PR checklist items.	Add a comprehensive description covering the changes (delayed_transfer wrap API change), the reason for the backport, and complete the PR checklist with information about tests and documentation updates.
Title check	❓ Inconclusive	The title 'Backport v1.0.0 delayed fix' is vague and generic, using non-descriptive terms that don't clearly convey the specific nature of the changes.	Provide a more specific title that describes the main API change, such as 'Update wrap function to accept recipient parameter and transfer wrapper' or similar.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch backport/release-v1.0.0-delayed-fix

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (0087566) to head (de28655).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files          19       19           
  Lines        1785     1785           
  Branches      484      484           
=======================================
  Hits         1602     1602           
  Misses        168      168           
  Partials       15       15           

Flag	Coverage Δ
contracts/access	44.87% <100.00%> (ø)
math/core	86.12% <ø> (ø)
math/fixed_point	57.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

contracts/access/tests/delayed_tests.move (1)

492-519: ⚠️ Potential issue | 🟡 Minor

Make the fallback cleanup path actually reachable.

These helpers still try to unwrap at t = 1 even though the wrappers were created with a 5ms delay. If the expected return_val abort ever regresses, the test will fail with EDelayNotElapsed instead of the invariant you're trying to check.

Proposed fix

 fun expect_return_wrong_wrapper(
     mut first: delayed_transfer::DelayedTransferWrapper<DummyCap>,
     mut second: delayed_transfer::DelayedTransferWrapper<DummyCap>,
     ctx: &mut TxContext,
 ) {
     let (obj, token) = first.borrow_val();
     second.return_val(obj, token);

     let mut clk = clock::create_for_testing(ctx);
     clk.set_for_testing(1);
     first.schedule_unwrap(&clk, ctx);
     second.schedule_unwrap(&clk, ctx);
+    clk.set_for_testing(6);
     let cap_first = first.unwrap(&clk, ctx);
     let DummyCap { id } = cap_first;
     id.delete();
     let cap_second = second.unwrap(&clk, ctx);
     let DummyCap { id } = cap_second;
@@
 fun expect_return_wrong_object(
     mut wrapper: delayed_transfer::DelayedTransferWrapper<DummyCap>,
     ctx: &mut TxContext,
 ) {
     let (borrowed, token) = wrapper.borrow_val();
@@
     let mut clk = clock::create_for_testing(ctx);
     clk.set_for_testing(1);
     wrapper.schedule_unwrap(&clk, ctx);
+    clk.set_for_testing(6);
     let obj = wrapper.unwrap(&clk, ctx);
     let DummyCap { id } = obj;
     id.delete();
     clock::destroy_for_testing(clk);
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@contracts/access/tests/delayed_tests.move` around lines 492 - 519, The test
sets the test clock to 1ms but the DelayedTransferWrapper instances were created
with a 5ms delay, so the fallback cleanup path is never reached and the test can
abort with EDelayNotElapsed; update the test's clock advances (calls to
clock::create_for_testing(...); clk.set_for_testing(...)) in
expect_return_wrong_object (and similar places in the file where you call
schedule_unwrap/unwrap on delayed_transfer::DelayedTransferWrapper<DummyCap>) to
a value >= the configured 5ms delay (e.g., 5 or 6) so schedule_unwrap and unwrap
run the fallback path and the intended invariant is exercised.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@contracts/access/tests/delayed_tests.move`:
- Around line 492-519: The test sets the test clock to 1ms but the
DelayedTransferWrapper instances were created with a 5ms delay, so the fallback
cleanup path is never reached and the test can abort with EDelayNotElapsed;
update the test's clock advances (calls to clock::create_for_testing(...);
clk.set_for_testing(...)) in expect_return_wrong_object (and similar places in
the file where you call schedule_unwrap/unwrap on
delayed_transfer::DelayedTransferWrapper<DummyCap>) to a value >= the configured
5ms delay (e.g., 5 or 6) so schedule_unwrap and unwrap run the fallback path and
the intended invariant is exercised.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2d5086e5-4fd5-4821-ae67-41b503e97ff7

📥 Commits

Reviewing files that changed from the base of the PR and between 0087566 and de28655.

⛔ Files ignored due to path filters (4)

• audits/2026-03-PR183.pdf is excluded by !**/*.pdf
• audits/2026-03-v1.0.0.pdf is excluded by !**/*.pdf
• contracts/access/Move.lock is excluded by !**/*.lock
• math/core/Move.lock is excluded by !**/*.lock

📒 Files selected for processing (8)

• CHANGELOG.md
• audits/README.md
• contracts/access/Published.toml
• contracts/access/README.md
• contracts/access/sources/ownership_transfer/delayed.move
• contracts/access/tests/delayed_tests.move
• math/core/Published.toml
• math/core/tests/macros/math_ops.move

[immrsd]

LGTM