[L-01] VestingWallet audit - 417

[ericnordelo]

No description provided.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 86e746f6-53f9-4d10-94a8-7dbbe6da37b4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/vesting-wallet-audit-417-L-01

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Updates operational documentation around VestingWallet teardown to clarify retryability and stranded-funds risk in the presence of newly settled or in-flight funds.

Changes:

• Clarifies that destroy_empty can abort with EUnsweptFunds when third-party funds settle before teardown, so teardown should be treated as retryable (sweep then retry).
• Expands the warning that funds sent in the same checkpoint as teardown (or after UID deletion) may become permanently unrecoverable, recommending waiting at least one full checkpoint before teardown.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
contracts/finance/sources/vesting_wallet.move	Refines destroy_empty documentation to emphasize retryability on EUnsweptFunds and checkpoint-related stranded-funds risk.
contracts/finance/sources/vesting_wallet_linear.move	Updates linear wallet teardown docs to match core wallet guidance on retryability and checkpoint timing risks.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.36%. Comparing base (dec4e32) to head (dd48ddd).

Additional details and impacted files

@@              Coverage Diff              @@
##           release-v1.4     #463   +/-   ##
=============================================
  Coverage         80.36%   80.36%           
=============================================
  Files                25       25           
  Lines              1971     1971           
  Branches            679      678    -1     
=============================================
  Hits               1584     1584           
  Misses              350      350           
  Partials             37       37           

Flag	Coverage Δ
contracts/access	65.46% <ø> (ø)
contracts/finance	26.86% <ø> (ø)
contracts/utils	44.09% <ø> (ø)
math/fixed_point	56.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.