[N-02] VestingWallet audit - 417#465
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the event documentation in vesting_wallet.move to more precisely describe when Swept and Received events are emitted, aligning the comments with the actual no-op/emit behavior of sweep_settled and receive_and_deposit.
Changes:
- Refined
Sweptevent docstring to describe emission only when settled funds are actually swept (non-zero). - Refined
Receivedevent docstring and field comment to use “claim” terminology and clarify zero-value behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-v1.4 #465 +/- ##
=============================================
Coverage 80.36% 80.36%
=============================================
Files 25 25
Lines 1971 1971
Branches 679 679
=============================================
Hits 1584 1584
Misses 350 350
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.