Skip to content

[N-02] VestingWallet audit - 417#465

Open
ericnordelo wants to merge 1 commit into
release-v1.4from
fix/vesting-wallet-audit-417-N-02
Open

[N-02] VestingWallet audit - 417#465
ericnordelo wants to merge 1 commit into
release-v1.4from
fix/vesting-wallet-audit-417-N-02

Conversation

@ericnordelo

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 8, 2026 10:44
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 28ccb024-1da1-445d-8454-412093d46083

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vesting-wallet-audit-417-N-02

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the event documentation in vesting_wallet.move to more precisely describe when Swept and Received events are emitted, aligning the comments with the actual no-op/emit behavior of sweep_settled and receive_and_deposit.

Changes:

  • Refined Swept event docstring to describe emission only when settled funds are actually swept (non-zero).
  • Refined Received event docstring and field comment to use “claim” terminology and clarify zero-value behavior.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.36%. Comparing base (dec4e32) to head (3d16e9d).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-v1.4     #465   +/-   ##
=============================================
  Coverage         80.36%   80.36%           
=============================================
  Files                25       25           
  Lines              1971     1971           
  Branches            679      679           
=============================================
  Hits               1584     1584           
  Misses              350      350           
  Partials             37       37           
Flag Coverage Δ
contracts/access 65.46% <ø> (ø)
contracts/finance 26.86% <ø> (ø)
contracts/utils 44.09% <ø> (ø)
math/fixed_point 56.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants