-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A simple structure for the layers of the project #66
Conversation
I think so yes, considering it is a core part of the protocol (given the publish function will call the signal service)
I also like this separation :) |
Lol not sure what happened with formatting, but should be fixed now.
Would you put the folder outside |
I was thinking we could directly have
|
Note that Taiko’s L2/shared code is built with |
Agree with this,
Some contracts will be deployed on both sides, so I think different folders is not helpful information. Imo it's a documentation issue, the user should have concrete steps to deploy its rollup, where we can be more specific about L1/L2 |
We said it is important to distinguish what is a core protocol concern(e.g. PublicationFeed, CheckPointTracker and interfaces) vs extensions or application concerns(e.g. ERC20Bridge or the specific incentive mechanism for provers). This doc summarizes our current folder structure and here are also some open questions:
Questions
If
protocol
is the folder for core contracts of the stack:signal
inside protocol? I do consider L1<>L2 messaging and bridging ETH a core concern of the protocolprotocol
folder into L1, L2, shared similar to the current taiko-mono repo or are we better of with the current structure?