Signalling #89
Open
Signalling #89
+4,975
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo comments bytes memory
The value is what you want to signal i.e. a message. A signal is what actually ends up being stored
ggonzalez94
reviewed
Mar 28, 2025
| /// @dev Signal a `value` at a namespaced slot. See `deriveSlot`. | ||
| function signal(uint64 chainId, address account, bytes32 value) internal returns (bytes32) { | ||
| bytes32 slot = deriveSlot(chainId, account, value); | ||
| slot.getBytes32Slot().value = value; |
There was a problem hiding this comment.
Since we already have the storage slot, is there any gas savings from doing this directly with assembly? I'm not familiar with the implementation of getBytes32Slot, I'll check it out - this is just not to miss the idea
assembly {
sstore(slot, value)
}
There was a problem hiding this comment.
Hey, the implementation is:
function getBytes32Slot(bytes32 slot) internal pure returns (Bytes32Slot storage r) {
assembly ("memory-safe") {
r.slot := slot
}
}
Co-authored-by: Gustavo Gonzalez <[email protected]>
Co-authored-by: Gustavo Gonzalez <[email protected]>
LeoPatOZ
force-pushed
the
signal-service
branch
from
98f3244 to
89056bc
Compare
simplify comment updated event explain root
LeoPatOZ
force-pushed
the
signal-service
branch
from
aa0ee38 to
d7da73f
Compare
re-do order comment
LeoPatOZ
force-pushed
the
signal-service
branch
from
baa218e to
96c4b94
Compare
up skip
update typo
unused
No need to namespace LibSignal.deriveSlot from within LibSignal.sol Also, this is consistent with the other instance in this file
…up into signal-service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at adding additional signalling functionality.