Update Account and Paymaster to use Entrypoint v0.8.0 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestognw
previously approved these changes
Mar 26, 2025
| ); | ||
| } | ||
| } | ||
| abstract contract Account is AccountCore, ERC721Holder, ERC1155Holder, ERC7739 {} |
There was a problem hiding this comment.
I would consider removing Account whatsoever and just enable ERC721Holder, ERC1155Holder, ERC721 and ERC7739 as toggle features in Wizard.
We can keep this contract until we have the wizard version
There was a problem hiding this comment.
lets keep it for now, we can remove it in a further PR.
I would even consider renaming AccountCore to Account at that point
There was a problem hiding this comment.
Note: this will require a lot of mocks changes, so I'd definitelly do it in a separate PR.
Co-authored-by: Ernesto García <[email protected]>
ernestognw
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires OpenZeppelin/openzeppelin-contracts#5586