Skip to content

Remove unused imports with solhint plus extra rules#5661

Merged
ernestognw merged 3 commits intoOpenZeppelin:masterfrom
ernestognw:chore/solhint-rules
May 7, 2025
Merged

Remove unused imports with solhint plus extra rules#5661
ernestognw merged 3 commits intoOpenZeppelin:masterfrom
ernestognw:chore/solhint-rules

Conversation

@ernestognw
Copy link
Copy Markdown
Member

@ernestognw ernestognw commented May 2, 2025

Attempts to fix #4825. Added some rules I think may be fine

EDIT: As noted in #4825, enabling the rule would require multiple // solhint-disable no-unused-import lines. I think they're ugly so I re-scoped the PR to just remove those unnecessary imports I found

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 0a5f186

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw requested a review from arr00 May 2, 2025 21:06
@ernestognw ernestognw marked this pull request as ready for review May 2, 2025 21:06
@ernestognw ernestognw requested a review from gonzaotc May 2, 2025 21:07
@arr00
Copy link
Copy Markdown
Member

arr00 commented May 7, 2025

We don't already have the no-unused-import rule and it's not added here?

@ernestognw
Copy link
Copy Markdown
Member Author

ernestognw commented May 7, 2025

We don't already have the no-unused-import rule and it's not added here?

No, I removed it in this commit: 0a5f186

Comment thread solhint.config.js
@ernestognw ernestognw merged commit 4aaf40a into OpenZeppelin:master May 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand used solhint rules

2 participants