Skip to content

Test ethers 6.13.6-beta.1, use solc 0.8.27 and prague EVM version #5663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ernestognw
Copy link
Member

@ernestognw ernestognw commented May 2, 2025

Pre #5664

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 58c794e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented May 2, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​ethers@​6.13.7 ⏵ 6.13.6-beta.198 +110010092 +4100

View full report

@ernestognw ernestognw changed the title Test ethers 6.13.6-beta.1 Test ethers 6.13.6-beta.1, use solc 0.8.27 and prague EVM version May 3, 2025
@ernestognw ernestognw requested review from arr00, luiz-lvj and gonzaotc May 5, 2025 19:08
@ernestognw ernestognw merged commit 08566bf into OpenZeppelin:master May 5, 2025
17 checks passed
@ricmoo
Copy link

ricmoo commented May 7, 2025

Not really sure what this issue is for, but noticed it linked to EIP-7702 support in Ethers.

The latest Ethers now has EIP-7702 support, there is no need to use the experimental npm tag.

@ernestognw
Copy link
Member Author

That's weird. I'm working on this PR.

I'm upgrading ethers with:

npm install [email protected]

Also can confirm the package was upgraded from changes to the package-lock.json

diff --git a/package-lock.json b/package-lock.json
index e1b701838..14265ebdf 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -24,7 +24,7 @@
         "chai": "^4.2.0",
         "eslint": "^9.0.0",
         "eslint-config-prettier": "^10.0.0",
-        "ethers": "6.13.6-beta.1",
+        "ethers": "^6.13.7",
         "glob": "^11.0.0",
         "globals": "^16.0.0",
         "graphlib": "^2.1.8",
@@ -4483,9 +4483,9 @@
       }
     },
     "node_modules/ethers": {
-      "version": "6.13.6-beta.1",
-      "resolved": "https://registry.npmjs.org/ethers/-/ethers-6.13.6-beta.1.tgz",
-      "integrity": "sha512-sJZklf+m7QrlzYnOFbR0qHPqgYHeevbY98VIhzvnSdzhJVN/nNV/skKc/4wjyxbWRhK9t7r6ENcwUwLPjfxTLw==",
+      "version": "6.13.7",
+      "resolved": "https://registry.npmjs.org/ethers/-/ethers-6.13.7.tgz",
+      "integrity": "sha512-qbaJ0uIrjh+huP1Lad2f2QtzW5dcqSVjIzVH6yWB4dKoMuj2WqYz5aMeeQTCNpAKgTJBM5J9vcc2cYJ23UAimQ==",
       "dev": true,
       "funding": [
         {

However, if I run the tests, I keep getting:

1) AccountERC7702WithModules: ERC-7702 account with ERC-7579 modules supports
       "before each" hook for "should return the canonical entrypoint":
     TypeError: params.erc7702signer.authorize is not a function
      at ERC4337Helper.newAccount (test/helpers/erc4337.js:115:56)
      at fixture (test/account/examples/AccountERC7702WithModulesMock.test.js:30:16)
      at loadFixture (node_modules/@nomicfoundation/hardhat-network-helpers/src/loadFixture.ts:59:18)
      at Context.<anonymous> (test/account/examples/AccountERC7702WithModulesMock.test.js:50:25)

@ricmoo
Copy link

ricmoo commented May 7, 2025

Hmmm… v6.13.7 doesn’t have EIP-7702, but v6.14.0 does. Can you try with that version?

@ernestognw
Copy link
Member Author

It worked! Thanks. I just updated #5668 with the 6.14.0 version so I'm merging as soon as tests pass. Same for our community repository: OpenZeppelin/openzeppelin-community-contracts#139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants