-
Notifications
You must be signed in to change notification settings - Fork 12k
feat: add ERC7572 interface for contracts that expose contract level metadata #5686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: dc731cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @coffeexcoin,
If I remember correctly, this interface was discussed in the context of #5394. I think we would need to use the interface in 6909 if we approve this PR
Happy to make those changes - what would be the preferred method, just make 6909ContentURI implement this interface? |
Also happy to add erc20/721/1155 extensions that implement this if that would be desirable |
I'd keep it only for 6909 for now. Other standards like ERC721 and ERC1155 define their own metadata functions. Probably that's why we decided not to include this interface in the first place cc @arr00 |
@ernestognw do you think it's ok to add an event to an interface defined in an ERC? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERC-6909 specifications does not mention ERC-7572 (that is still draft). IMO that change is not desirable.
This PR introduces the interface for draft ERC-7572 to the set of interfaces in the package.
This interface is useful for contracts (particularly tokens) that wish to expose a set of metadata for the contract including icon, banner image, description, external url, etc.
PR Checklist
npx changeset add
)