forked from EFForg/privacybadger
-
Notifications
You must be signed in to change notification settings - Fork 0
Update privacybadger from upstream #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielrussellLA
wants to merge
68
commits into
master
Choose a base branch
from
druss-update-pb
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commercecloud.salesforce.com appears to be a static content CDN
Appears required by the Adobe Acrobat extension for Chrome.
eCommerce tools, blocking breaks category pages on dollargeneral.com
Video player widgets; should look into replacing with a (surrogate-powered?) placeholder. EFForg#1593
It's the "limited ads" URL: https://developers.google.com/publisher-tag/guides/general-best-practices
eCommerce product search
Photo widgets for travel sites
Login widget for academia
Video player
Required on (many) Scripps Local Media station sites. Might want to convert this to MDFP in the future: EFForg#1593
Realtime APIs
Adobe Animate-powered interactive widgets
All Chrome/Edge versions for now, not just Beta.
Use the dnt-request-cookies-test test subdomain instead. www.eff.org is not a dedicated test domain, and it does not allow nesting in frames at this point. Consequently, the test fixture is broken in MV3 land as www.eff.org is never seen by the async version of webRequest.onBeforeRequest().
When EFF's DNT policy checking has been disabled.
Also: - Verifies actual content loading - Switches all content filtering tests to new, service worker-free fixture (don't need that here)
Rather than the underlying _store object. Now all storage updates should go through setItem(), where we could observe and react as needed.
This avoids the class of bugs where we unintentionally update some property of an object value in one of our storage objects by modifying properties of the object value we received from getItem().
Following up on EFForg@4f47d93
Pointless as tabData shouldn't get populated for extension page tabs.
…pldate-privacybadger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.