Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow printing lease login URL without having to open a browser #89

Open
nelsonjchen opened this issue Jan 6, 2021 · 0 comments · May be fixed by #91
Open

Allow printing lease login URL without having to open a browser #89

nelsonjchen opened this issue Jan 6, 2021 · 0 comments · May be fixed by #91

Comments

@nelsonjchen
Copy link

Is your feature request related to a problem? Please describe.
dce leases login --open-browser requires a browser to be configured in the environment and will open in the default session of the default browser.

The "default" might not work for everyone or it could be broken.

Sometimes you may not want to open the console in your default browser and maybe in another profile with some other browser or browsing container. Or maybe your xdg-open or similar utility is busted like out of the box with WSL.

I've seen other utilities like Google ones offer a fallback to visit a URL printed out if an interactive web browser can't be called open for whatever reason.

Describe the solution you'd like
Have an option to print out the URL to be opened with dce leases login --open-browser and not actually open the browser.

Describe alternatives you've considered
I don't know where to search or what. This operation seems to differ by platform too. For me, I've setup xdg-open in WSL2 to actually open correctly to Windows. This might not work for other user setups.

Additional context
nelsonjchen added a commit to nelsonjchen/dce-cli that referenced this issue Jan 30, 2021
@nelsonjchen
Make opening URLs not fatal if a web browser cannot be opened from th…
61b3b87 
…e terminal

This is useful for environments where a launching a Desktop web browser
from the terminal is unavailable or inaccessible.

For me, that would WSL out of the box on Windows. A similar pattern can
be seen in Google CLIs.

Closes Optum#89
@nelsonjchen nelsonjchen linked a pull request Jan 30, 2021 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make opening URLs not fatal if a web browser cannot be opened from the terminal nelsonjchen/dce-cli
1 participant
@nelsonjchen