Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make opening URLs not fatal if a web browser cannot be opened from the terminal #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nelsonjchen
Copy link

Proposed changes

This is useful for environments where a launching a Desktop web browser
from the terminal is unavailable or inaccessible.

For me, that would WSL out of the box on Windows. A similar pattern can
be seen in Google CLIs.

Closes #89

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Closes #89

Further comments

…e terminal

This is useful for environments where a launching a Desktop web browser
from the terminal is unavailable or inaccessible.

For me, that would WSL out of the box on Windows. A similar pattern can
be seen in Google CLIs.

Closes Optum#89
@nelsonjchen nelsonjchen marked this pull request as ready for review January 30, 2021 07:26
@CLAassistant
Copy link

CLAassistant commented Mar 2, 2021

CLA assistant check
All committers have signed the CLA.

@amyschoen amyschoen requested a review from shubydo July 6, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow printing lease login URL without having to open a browser
3 participants