Skip to content

feat(checkbox,radio-button,switch): update design #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

feat(checkbox,radio-button,switch): update design #490

wants to merge 20 commits into from

Conversation

@Tayebsed93
Copy link
Collaborator

@Tayebsed93 Tayebsed93 commented Nov 17, 2025 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #465, #466, #467, #437, #434, #431, #433

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

@Tayebsed93 Tayebsed93 linked an issue Nov 17, 2025 that may be closed by this pull request
[Component Update] Standalone checkbox and radio button rounded corners #437
Open
@Tayebsed93 Tayebsed93 marked this pull request as ready for review November 17, 2025 21:04
@Tayebsed93 Tayebsed93 self-assigned this Nov 17, 2025
@Tayebsed93 Tayebsed93 force-pushed the 437-component-update-standalone-checkbox-and-radio-button-rounded-corners branch from de3e457 to 4b31015 Compare November 18, 2025 10:46
@Tayebsed93
Merge branch 'develop' into 437-component-update-standalone-checkbox-…
81b2fe1 
…and-radio-button-rounded-corners

# Conflicts:
#	app/CHANGELOG.md
#	ouds_core/CHANGELOG.md
@Tayebsed93
add errror message and update additional text
97fee74
@Tayebsed93 Tayebsed93 force-pushed the 437-component-update-standalone-checkbox-and-radio-button-rounded-corners branch from 115cf1b to 97fee74 Compare November 18, 2025 14:04
@AhmedAmineZr AhmedAmineZr self-requested a review November 19, 2025 15:32
@Tayebsed93
Copy link
Collaborator Author

Tayebsed93 commented Nov 20, 2025

📣 New Firebase App Distribution Alpha upload available 🚀 (Android)

Please, get the new build from App Tester app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: DesignToolbox (alpha) (510)
Version: 0.6.0
Build type: Alpha
Build details (GitHub): 466
cc @B3nz01d (product owner)
cc @Tayebsed93 @nouha06 @AhmedAmineZr (dev team)
cc @jerome-regnier (design team)

@Tayebsed93
Copy link
Collaborator Author

Tayebsed93 commented Nov 20, 2025

📣 New TestFlight Alpha upload available 🚀 (iOS)

Please, get the new build from TestFlight app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: Design Toolbox Flutter (510)
Version: 0.6.0
Build type: Alpha
Build details (GitHub): 466
cc @B3nz01d (product owner)
cc @Tayebsed93 @AhmedAmineZr @nouha06 (dev team)
cc @jerome-regnier (design team)
cc @pya35 (Accessibility)

@jerome-regnier
Copy link
Member

jerome-regnier commented Nov 21, 2025

Review Design Figma :

Checkbox
https://www.figma.com/design/yKtkEY1DOl7YDvmt7jq0QF/-OUDS-Core-Lib--Review?node-id=69995-23022&t=BqzWYLTOMdeQzmpp-1

Radio button :
https://www.figma.com/design/yKtkEY1DOl7YDvmt7jq0QF/-OUDS-Core-Lib--Review?node-id=69995-24183&t=BqzWYLTOMdeQzmpp-1

Switch :
https://www.figma.com/design/yKtkEY1DOl7YDvmt7jq0QF/-OUDS-Core-Lib--Review?node-id=69995-24170&t=BqzWYLTOMdeQzmpp-1

J’ai laissé les commentaires sur chaque composant. Il y a un décalage important des icônes pour les 3 composants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AhmedAmineZr AhmedAmineZr AhmedAmineZr approved these changes

Assignees

@Tayebsed93 Tayebsed93

Labels

⚛️ component 📱 demo app 📖 documentation Improvements or additions to documentation 🧰 library 🧬 token

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Component Update] Checkbox v2.4.0 [Component Update] Standalone checkbox and radio button rounded corners

3 participants

@Tayebsed93 @jerome-regnier @AhmedAmineZr